Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.9.1
-
Fix Version/s: 1.9.4
-
Component/s: Database activity module
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
As seen on moodle.org:
1) Search plugins database for lightbox and view the lightbox module result
2) Close window and and click a link for a different module:http://moodle.org/mod/data/view.php?d=13&rid=891
3) Notice how lightbox module is displayed for this link still
If the filter is reset we click that link again we get the relevant module (brainstorm). But this search behaviour affecting the result of module display is confusing
Attachments
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDL-18136 | Database pagination broken when searching for entries |
|
|
|
Activity
Hi Robert ,
jut saw you committed fix for this some hours ago. It looks perfect for me B-) but I would change this use of logical operators:
$filter || $search = '';
$search && $moreurl .= '&filter=1';
by more "standard" conditions. Not because they don't do their work but because of current coding style and readability.
Ciao 
Thanks a lot Robert. Trivial style change applied. Resolving as fixed.
Ciao
Yup, really annoying.
IMO, any link to the "view one" template should ignore current filters completely and go straight to the requested record (without resetting filters and so, just ignoring).
Assigning this to Robert (TIA!) and addressing to 1.9.2
Thanks for the report, Dan!
Ciao