Moodle

Blog Improvements / Blog Assignment (GSoC)

Details

  • Type: Improvement Improvement
  • Status: Development in progress Development in progress
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Assignment, Blog, Tags
  • Labels:
    None
  1. backup-patch-8-18-08.patch
    19/Aug/08 4:59 AM
    21 kB
    Joseph Morwick
  2. blog_improvement-7-1-08-patch.txt
    02/Jul/08 11:48 AM
    40 kB
    Joseph Morwick
  3. blog_improvement-7-4-08-patch.txt
    04/Jul/08 3:56 PM
    40 kB
    Mathieu Petit-Clair
  4. blogimprovements-8-18-08.patch
    18/Aug/08 12:43 PM
    125 kB
    Joseph Morwick
  5. blogimprovements-8-19-08.patch
    19/Aug/08 1:01 PM
    126 kB
    Joseph Morwick
  6. blogpatch-08-14-2008.patch
    15/Aug/08 9:32 AM
    120 kB
    Joseph Morwick
  7. blogpatch-8-12-2008.txt
    13/Aug/08 12:51 PM
    116 kB
    Joseph Morwick
  8. blogpatch-8-13-2008.txt
    14/Aug/08 7:53 AM
    118 kB
    Joseph Morwick
  9. weblib-patch-08-13-2008-2.txt
    14/Aug/08 7:54 AM
    0.8 kB
    Joseph Morwick

Issue Links

Activity

Hide
Joseph Morwick added a comment -

This patch contains all of my work so far. It is based off the current CVS snapshot.

Show
Joseph Morwick added a comment - This patch contains all of my work so far. It is based off the current CVS snapshot.
Hide
Mathieu Petit-Clair added a comment -

Hi Joey,

Patch looks good. A few comments:

  • I updated the /lib/db/upgrade.php file, it wasn't quite working
  • I have (on my local site) a lot of blog entries. After activating this patch, none of the older entries would show, until I created a new entry with an association (deactivating associations makes the blog posts display as they should)
  • print_error() expects a localized string .. the full string needs to go in /lang/en_utf8/[blog.php]

I'm looking forward to the rest of the features...! More on this next week, once I get a chance to show people around...

Show
Mathieu Petit-Clair added a comment - Hi Joey, Patch looks good. A few comments:
  • I updated the /lib/db/upgrade.php file, it wasn't quite working
  • I have (on my local site) a lot of blog entries. After activating this patch, none of the older entries would show, until I created a new entry with an association (deactivating associations makes the blog posts display as they should)
  • print_error() expects a localized string .. the full string needs to go in /lang/en_utf8/[blog.php]
I'm looking forward to the rest of the features...! More on this next week, once I get a chance to show people around...
Hide
Joseph Morwick added a comment -

update with everything but the backup stuff

Show
Joseph Morwick added a comment - update with everything but the backup stuff
Hide
Joseph Morwick added a comment -

updated to use the weblib patch provided here:

http://tracker.moodle.org/secure/ManageAttachments.jspa?id=27911

Show
Joseph Morwick added a comment - updated to use the weblib patch provided here: http://tracker.moodle.org/secure/ManageAttachments.jspa?id=27911
Hide
Joseph Morwick added a comment -

weblib patch to make the blog improvement patch, and other things, work better

Show
Joseph Morwick added a comment - weblib patch to make the blog improvement patch, and other things, work better
Hide
Joseph Morwick added a comment -

some bugs were introduced from old code somehow coming about, and a few others that seemed to be hanging around. This patch has those bugs fixed, along with a few other enhancements.

Show
Joseph Morwick added a comment - some bugs were introduced from old code somehow coming about, and a few others that seemed to be hanging around. This patch has those bugs fixed, along with a few other enhancements.
Hide
Mathieu Petit-Clair added a comment -

I've been testing this out for some time, patch applies cleanly (except for version.php - which is normal), along with most recent patch in MDL-16036 (lib/weblib.php).

It's working mostly fine for me, though I have a long list of warning and one fatal error in blog/lib.php .. the problem seem to be in lines 784/786, as "array" appears in the sql statement. I got there (/blog/index.php?postid=1) by clicking on "full entry" from the assignment grading screen (but I got there from some other link yesterday).

Some code formatting needs to be fixed (all "if" statement need to have { and }, event for one-liners), to follow the Moodle rules.

I couldn't find out how blogs associated to forum work. Didn't spend too much time on that though. I suppose we are at the point where writing some basic (end-user) documentation about how to use this patch would be good.

I wish the blog_fetch_entries_sql function (the previous bug seems to come from there) could be somewhat cleaned up. I know most of this has been part of Moodle for a really long time ... but if all this query building could be simplified (and use placeholders), it would look a lot better. Separate issue, I guess...

Show
Mathieu Petit-Clair added a comment - I've been testing this out for some time, patch applies cleanly (except for version.php - which is normal), along with most recent patch in MDL-16036 (lib/weblib.php). It's working mostly fine for me, though I have a long list of warning and one fatal error in blog/lib.php .. the problem seem to be in lines 784/786, as "array" appears in the sql statement. I got there (/blog/index.php?postid=1) by clicking on "full entry" from the assignment grading screen (but I got there from some other link yesterday). Some code formatting needs to be fixed (all "if" statement need to have { and }, event for one-liners), to follow the Moodle rules. I couldn't find out how blogs associated to forum work. Didn't spend too much time on that though. I suppose we are at the point where writing some basic (end-user) documentation about how to use this patch would be good. I wish the blog_fetch_entries_sql function (the previous bug seems to come from there) could be somewhat cleaned up. I know most of this has been part of Moodle for a really long time ... but if all this query building could be simplified (and use placeholders), it would look a lot better. Separate issue, I guess...
Hide
Joseph Morwick added a comment -

This new patch (8-18-08) fixes the last mentioned bugs and a few more that I found.

I have separated out two bugfixes that had been included in previous patches and made seperate patches for them since they are general bugs and not just related to this project:

http://tracker.moodle.org/browse/MDL-16097
http://tracker.moodle.org/browse/MDL-16096

The code in this lastest patch (8-18-08) has been tested quite a bit. Tomorrow I'll attach a patch with all of my backup work. Since the backup system is in flux, I haven't been able to complete a full patch for this functionality yet, but I hope that the patch I do attach will be helpful.

Show
Joseph Morwick added a comment - This new patch (8-18-08) fixes the last mentioned bugs and a few more that I found. I have separated out two bugfixes that had been included in previous patches and made seperate patches for them since they are general bugs and not just related to this project: http://tracker.moodle.org/browse/MDL-16097 http://tracker.moodle.org/browse/MDL-16096 The code in this lastest patch (8-18-08) has been tested quite a bit. Tomorrow I'll attach a patch with all of my backup work. Since the backup system is in flux, I haven't been able to complete a full patch for this functionality yet, but I hope that the patch I do attach will be helpful.
Hide
Mathieu Petit-Clair added a comment -

I committed all three extra patches to CVS. I'll have a look at this one later, or tomorrow...

Show
Mathieu Petit-Clair added a comment - I committed all three extra patches to CVS. I'll have a look at this one later, or tomorrow...
Hide
Joseph Morwick added a comment -

I'm not yet able to test backup/restore code since there are some fatal errors preventing me from doing so, so I did my best to complete the backup/restore code without testing it (since today is the GSoC deadline). I have no idea if it is bugfree, and so must assume that it is not, and will probably need editing. I'm happy to do this myself, but it will not be able to be part of my GSoC project for this summer. I'm attaching a patch with the edits that I made.

Show
Joseph Morwick added a comment - I'm not yet able to test backup/restore code since there are some fatal errors preventing me from doing so, so I did my best to complete the backup/restore code without testing it (since today is the GSoC deadline). I have no idea if it is bugfree, and so must assume that it is not, and will probably need editing. I'm happy to do this myself, but it will not be able to be part of my GSoC project for this summer. I'm attaching a patch with the edits that I made.
Hide
Joseph Morwick added a comment -

some minor improvements were made with version 8-19-08

Show
Joseph Morwick added a comment - some minor improvements were made with version 8-19-08

People

Vote (2)
Watch (5)

Dates

  • Created:
    Updated: