|
[
Permalink
| « Hide
]
Joseph Morwick added a comment - 02/Jul/08 11:48 AM
This patch contains all of my work so far. It is based off the current CVS snapshot.
Hi Joey,
Patch looks good. A few comments:
I'm looking forward to the rest of the features...! More on this next week, once I get a chance to show people around... update with everything but the backup stuff
updated to use the weblib patch provided here:
http://tracker.moodle.org/secure/ManageAttachments.jspa?id=27911 weblib patch to make the blog improvement patch, and other things, work better
some bugs were introduced from old code somehow coming about, and a few others that seemed to be hanging around. This patch has those bugs fixed, along with a few other enhancements.
I've been testing this out for some time, patch applies cleanly (except for version.php - which is normal), along with most recent patch in
It's working mostly fine for me, though I have a long list of warning and one fatal error in blog/lib.php .. the problem seem to be in lines 784/786, as "array" appears in the sql statement. I got there (/blog/index.php?postid=1) by clicking on "full entry" from the assignment grading screen (but I got there from some other link yesterday). Some code formatting needs to be fixed (all "if" statement need to have { and }, event for one-liners), to follow the Moodle rules. I couldn't find out how blogs associated to forum work. Didn't spend too much time on that though. I suppose we are at the point where writing some basic (end-user) documentation about how to use this patch would be good. I wish the blog_fetch_entries_sql function (the previous bug seems to come from there) could be somewhat cleaned up. I know most of this has been part of Moodle for a really long time ... but if all this query building could be simplified (and use placeholders), it would look a lot better. Separate issue, I guess... This new patch (8-18-08) fixes the last mentioned bugs and a few more that I found.
I have separated out two bugfixes that had been included in previous patches and made seperate patches for them since they are general bugs and not just related to this project: http://tracker.moodle.org/browse/MDL-16097 The code in this lastest patch (8-18-08) has been tested quite a bit. Tomorrow I'll attach a patch with all of my backup work. Since the backup system is in flux, I haven't been able to complete a full patch for this functionality yet, but I hope that the patch I do attach will be helpful. I committed all three extra patches to CVS. I'll have a look at this one later, or tomorrow...
I'm not yet able to test backup/restore code since there are some fatal errors preventing me from doing so, so I did my best to complete the backup/restore code without testing it (since today is the GSoC deadline). I have no idea if it is bugfree, and so must assume that it is not, and will probably need editing. I'm happy to do this myself, but it will not be able to be part of my GSoC project for this summer. I'm attaching a patch with the edits that I made.
some minor improvements were made with version 8-19-08
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Improvement
In Progress
Minor
Blog Improvements / Blog Assignment (GSoC)
 |
|
