Moodle

Some oddities in admin/report/courseoverview

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

It seems that the migration of admin/report/courseoverview to support new DDL API was wrong:

http://cvs.moodle.org/moodle/admin/report/courseoverview/index.php?r1=1.20&r2=1.21

apart from the "$pram" typo in line 80, those >params doesn't exist at all and also, there is one $param>timeafter hardcoded in the query.

Ciao

Activity

Hide
Petr Škoda (skodak) added a comment -

I hate this spaghetti reports sql, I hope I fixed it but not sure

Show
Petr Škoda (skodak) added a comment - I hate this spaghetti reports sql, I hope I fixed it but not sure
Hide
Petr Škoda (skodak) added a comment -

closing, thanks

Show
Petr Škoda (skodak) added a comment - closing, thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: