[#MDL-15491] Forum ratings for summed scales are counterintuitive - Moodle Tracker

Details

Type: Bug
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: 1.9.1
Fix Version/s: None
Component/s: Forum
Labels:
None

Affected Branches:
MOODLE_19_STABLE

Description

Based on slashdot's rather nice discussion moderation system, I wanted to grade my students based on the number of points they had gained from other students, so set the ratings to 'sum of all ratings'. However, If I give each student the ability to use a scale with only one point, the maximum any post can get is the top of the scale, i.e. one point. Not much use.

What is needed is a way to specify a maximum grade for the summed ratings which is higher than the maximum for the scale. Discussion on ~~MDL-13804~~ suggested the need for an open ended grade with no maximum, but I think this is unecessary and undesirable.

Issue Links

This issue will be resolved by:
MDL-12380	In practice, grades can go over 100%

This issue has a non-specific relationship to:
MDL-13804	forum sum ratings are broken/ counterintuitive for star scales

Activity

Hide

Permalink

Nadav Kavalerchik added a comment - 19/Jun/09 8:08 PM

inside moodle/mod/forum/lib.php , function forum_get_ratings_sum()
i remarked the inside of the IF :

if ($total > $scale[$scalecount]) { //if the total exceeds the max grade then set it to the max grade
            //$total = $scale[$scalecount];
        }

seems to work fine with a "Stars" scale we made up (,,*,**,****)
i hope i did not break other parts of the SUM ratings in other forums.

thou it seems ok so far, i would really appreciate some code review

Show

Nadav Kavalerchik added a comment - 19/Jun/09 8:08 PM inside moodle/mod/forum/lib.php , function forum_get_ratings_sum() i remarked the inside of the IF :

if ($total > $scale[$scalecount]) { //if the total exceeds the max grade then set it to the max grade
            //$total = $scale[$scalecount];
        }

seems to work fine with a "Stars" scale we made up (,,*,**,****) i hope i did not break other parts of the SUM ratings in other forums. thou it seems ok so far, i would really appreciate some code review

People

Assignee:

moodle.com

Reporter:

Matt Gibson

Participants:

Matt Gibson, moodle.com, Nadav Kavalerchik

Vote (3)

Watch (3)

Dates

Created:

01/Jul/08 6:44 PM

Updated:

08/Nov/11 1:18 PM