Issue Details (XML | Word | Printable)

Key: MDL-15494
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

No allowance for the possibility that something might go wrong when processing the response to a question

Created: 01/Jul/08 09:20 PM   Updated: 02/Jul/08 05:16 PM
Return to search
Component/s: Questions
Affects Version/s: 1.9.1
Fix Version/s: 1.9.2

Participants: Tim Hunt
Security Level: None
Resolved date: 02/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Well, at the moment, question_process_responses in questionlib.php can return true of false to indicate success/failure, as can default_questiontype::grade_responses. However, question_process_responses ingores the return value of default_questiontype::grade_responses, and mod/quiz/attempt.php and question/preview.php ignore the return code from question_process_responses.

I need to put in the necessary error handling.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 5 files to 'Moodle CVS' - 01/Jul/08 09:34 PM
MDL-15494 - No allowance for the possibility that something might go wrong when processing the response to a question.
MODIFY question/preview.php   Rev. 1.29    (+5 -2 lines)
MODIFY mod/quiz/attempt.php   Rev. 1.146    (+31 -5 lines)
MODIFY lang/en_utf8/question.php   Rev. 1.19    (+1 -0 lines)
MODIFY question/type/description/questiontype.php   Rev. 1.16    (+2 -1 lines)
MODIFY lib/questionlib.php   Rev. 1.143    (+8 -4 lines)
tjhunt committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Jul/08 05:14 PM
MDL-15494 - No allowance for the possibility that something might go wrong when processing the response to a question. Backported from HEAD.
MODIFY lib/questionlib.php   Rev. 1.119.2.12    (+8 -4 lines)
MODIFY mod/quiz/attempt.php   Rev. 1.131.2.10    (+32 -5 lines)
MODIFY lang/en_utf8/question.php   Rev. 1.7.2.4    (+1 -0 lines)
MODIFY question/type/description/questiontype.php   Rev. 1.11.2.4    (+2 -1 lines)
MODIFY question/preview.php   Rev. 1.23.2.4    (+5 -2 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 03/Jul/08 05:37 AM
Translated a new string for question MDL-15494.
Translated new strings for tag MDL-11992.
MODIFY ja_utf8/README   Rev. 1.750    (+1 -1 lines)
MODIFY ja_utf8/tag.php   Rev. 1.14    (+10 -3 lines)
MODIFY ja_utf8/question.php   Rev. 1.21    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 05/Jul/08 05:33 PM
MDL-15494 new string
MODIFY fr_utf8/question.php   Rev. 1.28    (+2 -1 lines)