[#MDL-15494] No allowance for the possibility that something might go wrong when processing the response to a question - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 1.9.1
Fix Version/s: 1.9.2
Component/s: Questions
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

Well, at the moment, question_process_responses in questionlib.php can return true of false to indicate success/failure, as can default_questiontype::grade_responses. However, question_process_responses ingores the return value of default_questiontype::grade_responses, and mod/quiz/attempt.php and question/preview.php ignore the return code from question_process_responses.

I need to put in the necessary error handling.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 01/Jul/08 9:34 PM

Fix checked in to Moodle 2.0. Will be backported to 1.9 branch tomorrow.

Show

Tim Hunt added a comment - 01/Jul/08 9:34 PM Fix checked in to Moodle 2.0. Will be backported to 1.9 branch tomorrow.

Hide

Permalink

Tim Hunt added a comment - 02/Jul/08 5:16 PM

Backported to 1.9 now.

Note to testers: This is a rather difficult one to test, since for all the core question types, it should have no noticeable effect. However, you could check that a quiz using one of each question type still works in both adaptive and non-adaptive mode. This is essential for more advanced plugin question types.

Show

Tim Hunt added a comment - 02/Jul/08 5:16 PM Backported to 1.9 now. Note to testers: This is a rather difficult one to test, since for all the core question types, it should have no noticeable effect. However, you could check that a quiz using one of each question type still works in both adaptive and non-adaptive mode. This is essential for more advanced plugin question types.

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Participants:

Tim Hunt

Vote (0)

Watch (0)

Dates

Created:

01/Jul/08 9:20 PM

Updated:

17/Dec/10 1:03 PM

Resolved:

02/Jul/08 5:16 PM