Details
Sub-task
Closed
Minor
Description
The first part of the conditional activities system is completion tracking.
This has three parts:
1) Letting users to manually indicate that they have completed an activity.
2) Letting activities automatically indicate that a user has completed them (e.g. when a grade is assigned).
3) Providing a way for teachers to view the progress (either kind) of their students.
So this system is a complete feature in its own right. We will also be using the completion information to trigger conditional availability of activities, later.
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Great - thanks. I can't start work on the second part (controlling activity availability) until this one is in, so the sooner the better, and good luck with the freeze. 
[I'm not twiddling my thumbs, there's plenty of local stuff to do - just that if I don't do the availability bit soonish, I'll have to mess about / argue a bit to get it scheduled later.]
[I'm not twiddling my thumbs, there's plenty of local stuff to do - just that if I don't do the availability bit soonish, I'll have to mess about / argue a bit to get it scheduled later.] I am not able to start another task during the next 14 days, sorry 
Thanks Eloy!
1) I normally use INT(9) for small numbers that I am expecting to be <100 as it saves space etc (on 32-bit systems anyway). Is that bad? I can make them INT(10) if you like. All the Moodle IDs are or should be INT(10).
2) oops
3) correct - the JS is used mainly for students to tick checkboxes, if you don't have JS then this works also (goes to another http, redirects back).
4) OK, those exceptions were temporary anyway (don't use proper moodle exception class, because it doesn't/didn't exist). What I'll do is change all the exceptions to call a temporary, deprecated completion_throw_exception function that actually just calls print_error for now. Then we can search/replace the calls to that function with real throw whateverexception once exceptions are agreed.
5) We did but I thought it made the API too complicated and wasn't helpful for module implementors mainly because it wasn't really going to be possible to do it independent of other module code. I think Martin was ok with that (he was reading those emails).
6) Gradeitemnumbers don't need recoding because it's an index number that begins with 0 (in fact it is basically always 0) and not an id.
7) yay
I really, really to commit this stuff on Monday at latest as I am running out ot time allocated to this project. So if somebody can give that other +1 (even if it's just based on eloy's...)
I really, really to commit this stuff on Monday at latest as I am running out ot time allocated to this project. So if somebody can give that other +1 (even if it's just based on eloy's...) 1) Ah, for numbers up to 100 all you need is INT(3) then (if to save space is the objective, the number is the number of digits in xmldb slang).
2-3-4-6-7) 
5) sniff, sniff (np, anyway).
Here it's one more vote from Step Pilgrim: +1 :-D
Ciao
5) sniff, sniff (np, anyway).
Here it's one more vote from Step Pilgrim: +1 :-D
Ciao 1/ grade_grade::notify_changed()
the global $restore is a hack, what is we have some other $restore global elsewhere?
2/ grade_grade::notify_changed()
if(!empty($COURSE)) {
$course=$COURSE;
} else {
$this->load_grade_item();
$course=get_record('course','id',$grade_item->courseid);
}
this is incorrect, you have to test for $COURSE->id == $grade_item->courseid, not empty($COURSE); $COURSE always exists, you might get another course
3/ {$CFG->prefix}modules is not used anymore - use {moduels} instead
4/ grade_grade::notify_changed()
$cm=$DB->get_record_sql(", would get_coursemodule_from_instance() do the same?
5/ grade_grade::notify_changed()
$course=get_record('course','id',$grade_item->courseid);
grrrrrrrrr
6/ contructors should use __contruct() - not my idea
Here is my patch that implements the completion system.
This does not include support for more module types. I intend to add support for the 'view' completion condition to most modules. That will be done after the patch is checked in. Similarly, I think there are some missing help files, I will add these.
The patch does not include binaries; there are some new icons (as described in the design) which I will check in. At present the icons are produced by me, I hope to replace them with graphic-designed ones if appropriate.
As requested I have added unit testing and modified the system so that it is object-oriented (sort of) and therefore easier to test. I have also added a manual test procedure (.txt file) that can be carried out by QA staff.
The unit test completes successfully. At present, the manual test procedure cannot be completed because there is a bug in quiz that prevents you submitting a quiz. If you skip the quiz-related parts, it works.
I realise this patch is very long (168KB) - precisely for that reason I'd like to check it in asap (perhaps even if there are minor problems) as keeping it merged may be a challenge.