[#MDL-15500] Lots of warning messages when turn on the Debug messages (NORMAL: Show errors, warnings and notices) - Moodle Tracker

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9, 1.9.1
Fix Version/s: 1.9.2
Component/s: Libraries, Usability
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

When access the "Site Administration" block (login as admin) and try to "Add a new user" (or do something in the Accounts area), if you turn on the debugging mode (see screenshots), you will get a lot of warning messages. Seems like lib/weblib.php could use some clean up maybe...

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

debug_setting.png

24 kB

02/Jul/08 2:50 AM
warning_messages.png

27 kB

02/Jul/08 2:50 AM

Issue Links

This issue has a non-specific relationship to:
MDL-14635	glossary block help contains tags

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 02/Jul/08 7:36 AM

Yup, thanks Wen Hao!

that's one change we introduced recently about how the help buttons are printed. So, while keeping BC compatibility... we output that debug info.

IMO this must be addressed by:

Change that debug to DEBUG_DEVELOPER level (hasn't sense to have it in NORMAL level)
Fix the helpbutton() to use correct parameters.
Perhaps we could look for current calls to that function using the $text parameter and fix all them?

Dongsheng, can you, please? I think Mathieu did those changes in helpbutton() function. Sure he can comment you about the correct way. I'm not 100% sure about that.

TIA!

Show

Eloy Lafuente (stronk7) added a comment - 02/Jul/08 7:36 AM Yup, thanks Wen Hao! that's one change we introduced recently about how the help buttons are printed. So, while keeping BC compatibility... we output that debug info. IMO this must be addressed by:

Change that debug to DEBUG_DEVELOPER level (hasn't sense to have it in NORMAL level)
Fix the helpbutton() to use correct parameters.
Perhaps we could look for current calls to that function using the $text parameter and fix all them?

Dongsheng, can you, please? I think Mathieu did those changes in helpbutton() function. Sure he can comment you about the correct way. I'm not 100% sure about that. TIA!

Hide

Permalink

Dongsheng Cai added a comment - 02/Jul/08 2:26 PM

Hi, Eloy, this issue is caused by user/editadvanced_form.php line 38.
The array parameter will pass to helpbutton() function, if I remove $text parameter, I need to create new help file in lang/en_utf8/help (may be many help files need to be created). If you agree, I can start to create more help files for helpbutton().

I change debug level first.

Show

Dongsheng Cai added a comment - 02/Jul/08 2:26 PM Hi, Eloy, this issue is caused by user/editadvanced_form.php line 38. The array parameter will pass to helpbutton() function, if I remove $text parameter, I need to create new help file in lang/en_utf8/help (may be many help files need to be created). If you agree, I can start to create more help files for helpbutton(). I change debug level first.

Hide

Permalink

Dongsheng Cai added a comment - 02/Jul/08 2:27 PM - edited

I forgot adding you to watch list, need further discussion.

Show

Dongsheng Cai added a comment - 02/Jul/08 2:27 PM - edited I forgot adding you to watch list, need further discussion.

Hide

Permalink

Petr Škoda (skodak) added a comment - 05/Jul/08 6:47 PM

I guess this was already fixed this week, closing

thanks

Show

Petr Škoda (skodak) added a comment - 05/Jul/08 6:47 PM I guess this was already fixed this week, closing thanks

People

Assignee:

Dongsheng Cai

Reporter:

Wen Hao Chuang

Tester:

Petr Škoda (skodak)

Participants:

Dongsheng Cai, Eloy Lafuente (stronk7), Petr Škoda (skodak), Wen Hao Chuang

Vote (0)

Watch (1)

Dates

Created:

02/Jul/08 2:50 AM

Updated:

09/Jul/08 6:38 PM

Resolved:

05/Jul/08 6:47 PM