[#MDL-15500] Lots of warning messages when turn on the Debug messages (NORMAL: Show errors, warnings and notices)

Issue Details (XML | Word | Printable)

Key:	MDL-15500
Type:	Improvement
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Dongsheng Cai
Reporter:	Wen Hao Chuang
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Lots of warning messages when turn on the Debug messages (NORMAL: Show errors, warnings and notices)

Created: 02/Jul/08 02:50 AM Updated: 09/Jul/08 06:38 PM

Return to search

Component/s:

Lib, Usability

Affects Version/s:

1.9, 1.9.1

Fix Version/s:

1.9.2

File Attachments:

None

Image Attachments:

1. debug_setting.png
(24 kB)

2. warning_messages.png
(27 kB)

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-14635~~ glossary block help contains tags

Participants:	Dongsheng Cai, Eloy Lafuente (stronk7), Petr Skoda and Wen Hao Chuang
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	05/Jul/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

When access the "Site Administration" block (login as admin) and try to "Add a new user" (or do something in the Accounts area), if you turn on the debugging mode (see screenshots), you will get a lot of warning messages. Seems like lib/weblib.php could use some clean up maybe...

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 02/Jul/08 07:36 AM

Yup, thanks Wen Hao!

that's one change we introduced recently about how the help buttons are printed. So, while keeping BC compatibility... we output that debug info.

IMO this must be addressed by:

Change that debug to DEBUG_DEVELOPER level (hasn't sense to have it in NORMAL level)
Fix the helpbutton() to use correct parameters.
Perhaps we could look for current calls to that function using the $text parameter and fix all them?

Dongsheng, can you, please? I think Mathieu did those changes in helpbutton() function. Sure he can comment you about the correct way. I'm not 100% sure about that.

TIA!

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 02/Jul/08 02:26 PM

Hi, Eloy, this issue is caused by user/editadvanced_form.php line 38.
The array parameter will pass to helpbutton() function, if I remove $text parameter, I need to create new help file in lang/en_utf8/help (may be many help files need to be created). If you agree, I can start to create more help files for helpbutton().

I change debug level first.

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 02/Jul/08 02:27 PM - edited

I forgot adding you to watch list, need further discussion.

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Jul/08 06:47 PM

I guess this was already fixed this week, closing

thanks

All content on this web site is made available under the GNU General Public License, unless otherwise stated.