Issue Details (XML | Word | Printable)

Key: MDL-15501
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Kenneth Newquist
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

"Add Blocks" block doesn't use standard formatting

Created: 02/Jul/08 05:10 AM   Updated: 09/Jul/08 06:37 PM
Return to search
Component/s: Accessibility, Blocks, Themes
Affects Version/s: 1.8.5, 1.9.1
Fix Version/s: 1.8.6, 1.9.2

File Attachments: 1. Text File blocklib_addblock_patch.txt (0.5 kB)

Environment: Moodle 1.9.1 (Build: 20080515), PHP 5.2.0, MySQL 5.0.27, RHEL 4

Participants: Dongsheng Cai, Eloy Lafuente (stronk7), Kenneth Newquist and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 02/Jul/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
This is a minor issue, but it created problems in our custom theme.

Most blocks in Moodle use this XHTML code:

<div class="header"><div class="title"><h2>Upcoming Events</h2>

However, the "Blocks" block,which appears when you turn editing on, and which is used to add blocks to a course, does not follow this scheme. Instead, it looks like this:

<div class="header">Blocks</div>

This causes problems with themes which are expecting the convention used with other blocks (the H2 tag in the other block was apparently added for accessibility reasons). In order to bring this block into line with the others, I suggest the attached patch, which adds the appropriate div and H2 tags to the header div.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 02/Jul/08 07:39 AM
Assigning to Dongsheng... targets are 18_STABLE, 19_STABLE and HEAD.

Thanks for the report!


Dongsheng Cai added a comment - 02/Jul/08 01:03 PM
Fixed for 1.8, 1.9 and head, please review

Kenneth Newquist added a comment - 02/Jul/08 09:42 PM
I tested it on Moodle 1.9.1+ (Build: 20080702) and it worked fine.

Petr Skoda added a comment - 09/Jul/08 06:37 PM
closing, thanks