Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.5, 1.9.1
• Fix Version/s: 1.8.6, 1.9.2
• Component/s: Accessibility, Blocks, Themes
• Labels:

  None
• Environment:

  Moodle 1.9.1 (Build: 20080515), PHP 5.2.0, MySQL 5.0.27, RHEL 4

This is a minor issue, but it created problems in our custom theme.

Most blocks in Moodle use this XHTML code:

<div class="header"><div class="title"><h2>Upcoming Events</h2>

However, the "Blocks" block,which appears when you turn editing on, and which is used to add blocks to a course, does not follow this scheme. Instead, it looks like this:

<div class="header">Blocks</div>

This causes problems with themes which are expecting the convention used with other blocks (the H2 tag in the other block was apparently added for accessibility reasons). In order to bring this block into line with the others, I suggest the attached patch, which adds the appropriate div and H2 tags to the header div.

1. 

   blocklib_addblock_patch.txt

   02/Jul/08 5:10 AM

   0.5 kB

   Kenneth Newquist

• Assignee:

  Dongsheng Cai

  Reporter:

  Kenneth Newquist

  Tester:

  Petr Škoda (skodak)

  Participants:

  Dongsheng Cai, Eloy Lafuente (stronk7), Kenneth Newquist, Petr Škoda (skodak)

• Created:

  02/Jul/08 5:10 AM

  Updated:

  09/Jul/08 6:37 PM

  Resolved:

  02/Jul/08 1:03 PM