|
|
|
Sub-Tasks:
|
All
|
Open
|
|
| Sub-Task Progress: |
|
|
|
No sub-tasks match this view.
|
|
|
This is a minor issue, but it created problems in our custom theme.
Most blocks in Moodle use this XHTML code:
<div class="header"><div class="title"><h2>Upcoming Events</h2>
However, the "Blocks" block,which appears when you turn editing on, and which is used to add blocks to a course, does not follow this scheme. Instead, it looks like this:
<div class="header">Blocks</div>
This causes problems with themes which are expecting the convention used with other blocks (the H2 tag in the other block was apparently added for accessibility reasons). In order to bring this block into line with the others, I suggest the attached patch, which adds the appropriate div and H2 tags to the header div.
|
|
Description
|
This is a minor issue, but it created problems in our custom theme.
Most blocks in Moodle use this XHTML code:
<div class="header"><div class="title"><h2>Upcoming Events</h2>
However, the "Blocks" block,which appears when you turn editing on, and which is used to add blocks to a course, does not follow this scheme. Instead, it looks like this:
<div class="header">Blocks</div>
This causes problems with themes which are expecting the convention used with other blocks (the H2 tag in the other block was apparently added for accessibility reasons). In order to bring this block into line with the others, I suggest the attached patch, which adds the appropriate div and H2 tags to the header div.
|
Show » |
made changes - 02/Jul/08 07:39 AM
| Field |
Original Value |
New Value |
|
Assignee
|
Eloy Lafuente (stronk7)
[ stronk7
]
|
Dongsheng Cai
[ dongsheng
]
|
made changes - 02/Jul/08 07:39 AM
|
Fix Version/s
|
|
1.8.6
[ 10270
]
|
|
Fix Version/s
|
|
1.9.2
[ 10280
]
|
committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Jul/08 01:01 PM
"MDL-15501, add appropriate div and h2 tags to the header div"
|
|
|
committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Jul/08 01:02 PM
"MDL-15501, add appropriate div and h2 tags to the header div, merged from MOODLE_18_STABLE"
|
|
|
committed 1 file to 'Moodle CVS' - 02/Jul/08 01:02 PM
"MDL-15501, add appropriate div and h2 tags to the header div, merged from MOODLE_19_STABLE"
|
|
|
made changes - 02/Jul/08 01:03 PM
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 02/Jul/08 01:12 PM
committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Jul/08 01:12 PM
committed 1 file to 'Moodle CVS' - 02/Jul/08 01:12 PM
made changes - 09/Jul/08 06:37 PM
|
Status
|
Resolved
[ 5
]
|
Closed
[ 6
]
|
|
QA Assignee
|
|
skodak
|
|
Bug
Closed
Minor
"Add Blocks" block doesn't use standard formatting
Thanks for the report!