Moodle

Add additional debugging to mnet functions

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.8.6, 1.9.1
  • Fix Version/s: None
  • Component/s: MNet
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Networking can be difficult to diagnose when it doesn't work. I propose to add debugging notices in appropriate places. Currently a lot of the code tends to fail silently on potential error conditions.

This will mostly be done with debugging() so as not to cause an regressions for users who may have a working system despite possible error conditions.

Issue Links

Activity

Hide
Howard Miller added a comment -

debugging added in the mnet block. Message displayed if authentication is not enabled (mnet auth must be on for block to be displayed)

Show
Howard Miller added a comment - debugging added in the mnet block. Message displayed if authentication is not enabled (mnet auth must be on for block to be displayed)
Hide
Petr Škoda (skodak) added a comment -

Is this finished?

Show
Petr Škoda (skodak) added a comment - Is this finished?
Hide
Howard Miller added a comment -

Short answer, no.

I need to have a look through for any more places where no checks of return values etc. are made. Next couple of days

Show
Howard Miller added a comment - Short answer, no. I need to have a look through for any more places where no checks of return values etc. are made. Next couple of days
Hide
Petr Škoda (skodak) added a comment -

short answer: np

Show
Petr Škoda (skodak) added a comment - short answer: np
Hide
Petr Škoda (skodak) added a comment -

:-D

Show
Petr Škoda (skodak) added a comment - :-D
Hide
Petr Škoda (skodak) added a comment -

thanks!

Show
Petr Škoda (skodak) added a comment - thanks!
Hide
Penny Leach added a comment -

hi howard,

how did you get on with this one ?

Show
Penny Leach added a comment - hi howard, how did you get on with this one ?
Hide
Penny Leach added a comment -

howard, i've committed a new mnet_debug message to head, which should help, if you want to check it out.

Show
Penny Leach added a comment - howard, i've committed a new mnet_debug message to head, which should help, if you want to check it out.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated: