[#MDL-15555] stop using span tag for nolink and lang, use the original custom moodle tags - Moodle Tracker

Details

Type: Task
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: 1.9
Fix Version/s: DEV backlog
Component/s: HTML Editor
Labels:
- triaged

Affected Branches:
MOODLE_19_STABLE

Description

The problem is that <span>s can not be nested - both because you can not have divs in spans and also it is later impossible to find the matching </span>

The reason for those unfortunate <span class="nolink"> and <span class="lang"> was that html editor did not support custom tags, this is not a cane anymore in tinymce of fckeditor.

Issue Links

This issue has been marked as being related by:
MDL-14582	Filters 2.0
MDL-4330	<span class="nolink"> does not work properly in all cases

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Dougiamas added a comment - 11/Dec/08 1:39 PM

Along with this, it would be nice if the filtering system broke up the texts into "linking" and "nolinking" chunks before sending them to the filters, so that the nolink tag always works for all filters.

I guess to be correct for this we need to do either one of these:

1) have all filters declare that they are "linking" type filters or not, so that we just apply to these.
2) change the tag name to "nofilter" and support "nolink" as a undocumented alternative for backward compatibility.

Show

Martin Dougiamas added a comment - 11/Dec/08 1:39 PM Along with this, it would be nice if the filtering system broke up the texts into "linking" and "nolinking" chunks before sending them to the filters, so that the nolink tag always works for all filters. I guess to be correct for this we need to do either one of these: 1) have all filters declare that they are "linking" type filters or not, so that we just apply to these. 2) change the tag name to "nofilter" and support "nolink" as a undocumented alternative for backward compatibility.

Hide

Permalink

Martin Dougiamas added a comment - 07/May/09 5:10 PM

Suggested syntax:

Show

Martin Dougiamas added a comment - 07/May/09 5:10 PM Suggested syntax: <nofilter except="mediaplugin multilang"> .... </nofilter>

Hide

Permalink

Petr Škoda (skodak) added a comment - 17/Dec/10 2:02 AM

Actually David proposed a lot better solution: use <nolinkstart />xxx<nolinkend /> - the reason is html purifier and tinymce can handle both span and div correctly - otehrwise the strict nesting rules are going to keep breaking everything....

Show

Petr Škoda (skodak) added a comment - 17/Dec/10 2:02 AM Actually David proposed a lot better solution: use <nolinkstart />xxx<nolinkend /> - the reason is html purifier and tinymce can handle both span and div correctly - otehrwise the strict nesting rules are going to keep breaking everything....

People

Assignee:

moodle.com

Reporter:

Petr Škoda (skodak)

Participants:

Martin Dougiamas, moodle.com, Petr Škoda (skodak)

Vote (3)

Watch (4)

Dates

Created:

07/Jul/08 7:09 AM

Updated:

17/Dec/10 3:31 AM