Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.9.1
-
Fix Version/s: 1.9.3
-
Component/s: MNet
-
Labels:None
-
Environment:Linux, php 4.3.10
-
Database:MySQL
-
URL:.../admin/mnet/mnet_themes.php?step=list&hostid=4
-
Affected Branches:MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
Error message:
Notice: Undefined variable: adminroot in .../moodle/admin/mnet/mnet_themes.html on line 2
To reproduce, turn on networking, create a host to connect to in Admin->Networking->Peers. After saving the host, when the tabs appear at the top, select the "Themes" tab.
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Petr Škoda (skodak)
added a comment -
require_once() is for library files with function definitions, require() should be imho used always if executing code from other scripts - works here, but does not seem to be promoting good coding style 
Show
Petr Škoda (skodak)
added a comment - require_once() is for library files with function definitions, require() should be imho used always if executing code from other scripts - works here, but does not seem to be promoting good coding style
Assigning to Dongsheng for 1.9.3. Thanks for the report!