Issue Details (XML | Word | Printable)

Key: MDL-15563
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Terri Matsakis
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

adminroot undefined in /admin/mnet/mnet_themes.php

Created: 08/Jul/08 12:27 AM   Updated: 22/Jul/08 08:19 PM
Return to search
Component/s: Networking
Affects Version/s: 1.9.1
Fix Version/s: 1.9.3

File Attachments: 1. Text File MDL-15563.patch (3 kB)
Environment: Linux, php 4.3.10

Database: MySQL
URL: .../admin/mnet/mnet_themes.php?step=list&hostid=4
Participants: Dongsheng Cai, Eloy Lafuente (stronk7), Petr Skoda and Terri Matsakis
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 09/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Error message:
Notice: Undefined variable: adminroot in .../moodle/admin/mnet/mnet_themes.html on line 2

To reproduce, turn on networking, create a host to connect to in Admin->Networking->Peers. After saving the host, when the tabs appear at the top, select the "Themes" tab.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 08/Jul/08 04:24 PM
Assigning to Dongsheng for 1.9.3. Thanks for the report!

[ Permalink | « Hide ]
Dongsheng Cai added a comment - 09/Jul/08 01:40 PM
A patch to fix this.

[ Permalink | « Hide ]
Dongsheng Cai added a comment - 09/Jul/08 05:33 PM
Please review, Thanks.

[ Permalink | « Hide ]
Petr Skoda added a comment - 09/Jul/08 07:00 PM
require_once() is for library files with function definitions, require() should be imho used always if executing code from other scripts - works here, but does not seem to be promoting good coding style

[ Permalink | « Hide ]
Dongsheng Cai added a comment - 10/Jul/08 09:53 AM
Thanks Petr, fixed.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators