[#MDL-15563] adminroot undefined in /admin/mnet/mnet_themes.php

Issue Details (XML | Word | Printable)

Key:	MDL-15563
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Dongsheng Cai
Reporter:	Terri Matsakis
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

adminroot undefined in /admin/mnet/mnet_themes.php

Created: 08/Jul/08 12:27 AM Updated: 22/Jul/08 08:19 PM

Return to search

Component/s:

Networking

Affects Version/s:

1.9.1

Fix Version/s:

1.9.3

File Attachments:	1. MDL-15563.patch (3 kB)
Environment:	Linux, php 4.3.10

Database:	MySQL
URL:	.../admin/mnet/mnet_themes.php?step=list&hostid=4
Participants:	Dongsheng Cai, Eloy Lafuente (stronk7), Petr Skoda and Terri Matsakis
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	09/Jul/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Error message:
Notice: Undefined variable: adminroot in .../moodle/admin/mnet/mnet_themes.html on line 2

To reproduce, turn on networking, create a host to connect to in Admin->Networking->Peers. After saving the host, when the tabs appear at the top, select the "Themes" tab.

All

Comments

Change History

Version Control

Sort Order:

Eloy Lafuente (stronk7) made changes - 08/Jul/08 04:24 PM

Field	Original Value	New Value
Fix Version/s		1.9.3 [ 10290 ]
Assignee	Nobody [ nobody ]	Dongsheng Cai [ dongsheng ]

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 08/Jul/08 04:24 PM

Assigning to Dongsheng for 1.9.3. Thanks for the report!

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 09/Jul/08 01:40 PM

A patch to fix this.

Dongsheng Cai made changes - 09/Jul/08 01:40 PM

Attachment

MDL-15563.patch [ 14494 ]

Dongsheng Cai committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/Jul/08 05:31 PM

~~MDL-15563~~, fix undefined variable in this page, and debugging information.

MODIFY	admin/mnet/mnet_themes.php		Rev. 1.1.2.2		(+2 -3 lines)
MODIFY	admin/mnet/mnet_themes.html		Rev. 1.1.2.1		(+9 -10 lines)

Dongsheng Cai committed 2 files to 'Moodle CVS' - 09/Jul/08 05:32 PM

~~MDL-15563~~, fix undefined variable and debugging information.

MODIFY	admin/mnet/mnet_themes.php		Rev. 1.4		(+2 -4 lines)
MODIFY	admin/mnet/mnet_themes.html		Rev. 1.2		(+13 -14 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 09/Jul/08 05:33 PM

Please review, Thanks.

Dongsheng Cai made changes - 09/Jul/08 05:33 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 09/Jul/08 07:00 PM

require_once() is for library files with function definitions, require() should be imho used always if executing code from other scripts - works here, but does not seem to be promoting good coding style