[#MDL-15610] mtable entry for \mod\label\db\install.xml should be label not quiz - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9.1
Fix Version/s: 1.9.2
Component/s: Resource
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

lines 26 and 27 of \mod\label\db\install.xml should be changed to refer to the table "label" rather than quiz.

This entry is to describe the table being affected by the action. I assume that this was a copy/paste error as the quiz table is not affected by the creation or update of a label.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Dougiamas added a comment - 11/Jul/08 10:57 AM

Yep looks like a copy/paste error from long ago. Well spotted, thanks!

Show

Martin Dougiamas added a comment - 11/Jul/08 10:57 AM Yep looks like a copy/paste error from long ago. Well spotted, thanks!

Hide

Permalink

Dongsheng Cai added a comment - 11/Jul/08 1:20 PM

Martin, execute_sql is not available in HEAD.

$sql = "UPDATE {log_display} SET mtable = 'label' WHERE module = 'label'";
$result = $DB->execute($sql);

Show

Dongsheng Cai added a comment - 11/Jul/08 1:20 PM Martin, execute_sql is not available in HEAD. $sql = "UPDATE {log_display} SET mtable = 'label' WHERE module = 'label'"; $result = $DB->execute($sql);

Hide

Permalink

Martin Dougiamas added a comment - 11/Jul/08 1:53 PM

Beautiful, thanks!

Show

Martin Dougiamas added a comment - 11/Jul/08 1:53 PM Beautiful, thanks!

Hide

Permalink

Petr Škoda (skodak) added a comment - 22/Jul/08 8:26 PM

reviewed, thanks

Show

Petr Škoda (skodak) added a comment - 22/Jul/08 8:26 PM reviewed, thanks

People

Assignee:

Martin Dougiamas

Reporter:

Gary Anderson

Tester:

Petr Škoda (skodak)

Participants:

Dongsheng Cai, Gary Anderson, Martin Dougiamas, Petr Škoda (skodak)

Vote (0)

Watch (0)

Dates

Created:

11/Jul/08 2:26 AM

Updated:

22/Jul/08 8:26 PM

Resolved:

11/Jul/08 10:57 AM