Moodle

Log entries of user messages indicates wrong table affected

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Not a bug
  • Affects Version/s: 1.9.1
  • Fix Version/s: 1.9.2
  • Component/s: Messages
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

the mtable entry of log_display should indicate which table is affected by the users action. In the case of messages, the table indicated is user, but it is actually message, message_contacts, or message_read.

Attached is a patch for the way it should be in /lib/db/install.xml. A better way is to probably make it an update script so it corrects old installations, but this file indicates the correct tables.

Similar to MDL-15610.

There are some other minor issues in these tables. For example, glossary add entry affects the glossary_entries table, not the glossary table, but this one and the label one are the most inaccurate.

Activity

Hide
Gary Anderson added a comment -

On further inspection, this does not appear to be a bug, although MDL-15610 is a bug.

Apparently mtable is used to give the table that the log report can use to give details about the action. In that case, the user table is probably correct.

Show
Gary Anderson added a comment - On further inspection, this does not appear to be a bug, although MDL-15610 is a bug. Apparently mtable is used to give the table that the log report can use to give details about the action. In that case, the user table is probably correct.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: