[#MDL-15619] Related Tag being incorrectly created

Issue Details (XML | Word | Printable)

Key:	MDL-15619
Type:	Bug
Status:	Open
Priority:	Major
Assignee:	Mathieu Petit-Clair
Reporter:	Jon Bolton
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Related Tag being incorrectly created

Created: 11/Jul/08 11:09 PM Updated: 16/Jul/08 05:12 AM

Return to search

Component/s:

Tags

Affects Version/s:

1.9.1

Fix Version/s:

None

File Attachments:	1. tag bug.zip (134 kB)
Environment:	Moodle 1.9.1+ (Build: 20080618), PHP Version 5.2.6, MySQL client version: 5.0.51a

Database:	MySQL
URL:	http://socialwork.fife.gov.uk/tag/index.php?id=7
Participants:	Jon Bolton and Mathieu Petit-Clair
Security Level:	None
Affected Branches:	MOODLE_19_STABLE

Description

« Hide

A tag that was once an official tag (but was subsequently 'downgraded') is being incorrectly linked to some other tags as related - and the relationship is not being reciproctaed to the other tag.

URL http://socialwork.fife.gov.uk/tag/index.php?id=7 shows the 'confidentiality' tag (tag id=7) as being related to the 'musings' tag (tag id=27). This correlation was not created by me (and no-one else has capability), but 'musings' is not related to 'confidentiality'. Tag relationship is also not showing as defined in the 'edit tag' screen.

'Musings' tag is tag id 27, and was once an official tag.

Attached zip file contains screenshot of mdl_tag_correlation table, some screenshots of various tags and edit_tags pages, and php info file

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Mathieu Petit-Clair added a comment - 15/Jul/08 09:44 AM

This is actually a feature: tags that are often used together end up being "correlated" automatically. There is no way to turn this off from the interface, but it would be a easy to prevent indexation: comment out the call to tag_compute_correlations in tag_cron function, in /tag/lib.php and then empty table tag_correlation in the database.

I suppose we should turn this one into a feature request and make this customizable from the interface.

[ Permalink | « Hide ]

Jon Bolton added a comment - 16/Jul/08 05:08 AM - edited

Thanks Mathieu, I understand what you're saying (I think), but I'm not sure why it's a feature. The benefit of related tags is that they ARE related - a spurious, automatic correlation just because 2 tags are frequently used together is not a relationship.

But I'd be happy with a config option in the interface... are you planning this on a 'per tag' basis? Eg. a switch between automatic and manual relationship for "this tag that I am editing now"?

Can I just clarify though (for my own sanity!) - my original issue report is about a tag that is only being related "one-way" - ie. one tag says it's related to another... but the 'related' tag is not showing the corresponding reverse relationship.

[ Permalink | « Hide ]

Jon Bolton added a comment - 16/Jul/08 05:09 AM

Oh, if I comment out the call to tag_compute_correlations as you suggest above, will that also stop manual creation of related tags... because I still want to be able to do that

All content on this web site is made available under the GNU General Public License, unless otherwise stated.