Moodle

In view assignments page, Last Modified column grows too wide

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9.1
  • Fix Version/s: None
  • Component/s: Assignment
  • Labels:
    None
  • Environment:
    Linux MySQL Ununtu platform Moodle Build 20080604
  • Affected Branches:
    MOODLE_19_STABLE

Description

When I specify multiple files for an upload type assignment, and review the submitted assignments the list of files does not wrap within the table column "last modified"

This creates a table with the greatly exceeds my browswer window, resulting in having to scroll left and right.

I believe this can easily be fixed the the following change to the assignment.class.php file in the mod/assignment/type/upload arround line 307 of the method print_student_answer

add a space just after the </a> in the line that addes the file line to $output:

$output .= '<a href="'.$ffurl.'" ><img class="icon" src="'.$CFG->pixpath.'/f/'.$icon.'" alt="'.$icon.'" />'.$file.'</a> ';

This will allow the browser to wrap when the list of file names exceeds the width.

I have attached a modifed assignment.class.php file

Activity

Hide
Susana Leitão added a comment -

Yes, it fixed (moodle 1.8.4+)

Show
Susana Leitão added a comment - Yes, it fixed (moodle 1.8.4+)
Hide
Tony Butler added a comment -

This is still broken in 1.9.4+ (a non-breaking space was used) and in IE6 the symptoms are worse: the offending cell fails to expand the rest of the table so the output is just cut off at the start of the next cell.

Probably a neater fix is to add a line break instead of a space (patch attached).

Show
Tony Butler added a comment - This is still broken in 1.9.4+ (a non-breaking space was used) and in IE6 the symptoms are worse: the offending cell fails to expand the rest of the table so the output is just cut off at the start of the next cell. Probably a neater fix is to add a line break instead of a space (patch attached).

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated: