Issue Details (XML | Word | Printable)

Key: MDL-15661
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Mathieu Petit-Clair
Reporter: Daniel Miksik
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Call to undefined function tag_set_type()

Created: 16/Jul/08 05:27 AM   Updated: 22/Jul/08 08:33 PM
Return to search
Component/s: Tags
Affects Version/s: 1.9.2
Fix Version/s: 1.9.3

Participants: Daniel Miksik, Mathieu Petit-Clair and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 16/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
I believe there is a typo bug in tag/manage.php calling an undefined function. See below the diff fixing this bug.


Index: tag/manage.php
===================================================================
RCS file: /cvsroot/moodle/moodle/tag/manage.php,v
retrieving revision 1.7.2.7
diff -c -r1.7.2.7 manage.php
*** tag/manage.php 2 Apr 2008 06:10:07 -0000 1.7.2.7
--- tag/manage.php 15 Jul 2008 21:18:12 -0000
***************
*** 117,123 ****
          foreach ( $new_otags as $new_otag ) {
              if ( $new_otag_id = tag_get_id($new_otag) ) {
                  // tag exists, change the type
! tag_set_type($new_otag_id, 'official');
              } else {
                  tag_add($new_otag, 'official');
              }
--- 117,123 ----
          foreach ( $new_otags as $new_otag ) {
              if ( $new_otag_id = tag_get_id($new_otag) ) {
                  // tag exists, change the type
! tag_type_set($new_otag_id, 'official');
              } else {
                  tag_add($new_otag, 'official');
              }

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Mathieu Petit-Clair committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 16/Jul/08 09:20 AM
MDL-15661: typo in function name - wrong call meant tag type was set incorrectly
MODIFY tag/manage.php   Rev. 1.7.2.8    (+2 -2 lines)
Mathieu Petit-Clair committed 1 file to 'Moodle CVS' - 16/Jul/08 09:21 AM
MDL-15661: typo in function name - wrong call meant tag type was set incorrectly (merge from 1.9)
MODIFY tag/manage.php   Rev. 1.17    (+2 -2 lines)
Mathieu Petit-Clair added a comment - 16/Jul/08 09:22 AM
Thanks for finding this one. Patch committed.

Mathieu Petit-Clair made changes - 16/Jul/08 09:22 AM
Field Original Value New Value
Fix Version/s 1.9.3 [ 10290 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Petr Skoda added a comment - 22/Jul/08 08:33 PM
reviewed, thanks

Petr Skoda made changes - 22/Jul/08 08:33 PM
QA Assignee skodak
Status Resolved [ 5 ] Closed [ 6 ]