[#MDL-15682] captcha notice found in logs

Issue Details (XML | Word | Printable)

Key:	MDL-15682
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Nicolas Connault
Reporter:	Eloy Lafuente (stronk7)
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

captcha notice found in logs

Created: 17/Jul/08 06:21 AM Updated: 25/Sep/08 05:00 PM

Return to search

Component/s:

Authentication

Affects Version/s:

1.9.2

Fix Version/s:

1.9.3

Database:	Any
Participants:	Eloy Lafuente (stronk7), Nicolas Connault and Petr Skoda
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	25/Sep/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Was looking some apache log files (at moodle.org) when I found a lot of:

PHP Notice: Undefined index: recaptcha_challenge_field in /var/www/html/moodle/login/signup_form.php on line 142, referer: http://moodle.org/login/signup.php

Ciao :-)

All

Comments

Change History

Version Control

Sort Order:

Nicolas Connault committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 23/Jul/08 01:21 PM

~~MDL-15682~~ Fixed

MODIFY	login/signup_form.php		Rev. 1.35.2.6		(+13 -9 lines)
MODIFY	lang/en_utf8/moodle.php		Rev. 1.141.2.42		(+4 -3 lines)

Nicolas Connault committed 2 files to 'Moodle CVS' - 23/Jul/08 01:23 PM

~~MDL-15682~~ Fixed, merged from MOODLE_19_STABLE

MODIFY	login/signup_form.php		Rev. 1.42		(+15 -9 lines)
MODIFY	lang/en_utf8/moodle.php		Rev. 1.187		(+3 -2 lines)

Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 24/Jul/08 12:40 AM

~~MDL-15682~~ Translated new string for reCAPTCHA.
~~MDL-8521~~ Translated new strings for safe overrides.

MODIFY	ja_utf8/role.php	Rev. 1.67	(+3 -1 lines)
MODIFY	ja_utf8/admin.php	Rev. 1.279	(+2 -1 lines)
MODIFY	ja_utf8/moodle.php	Rev. 1.303	(+2 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.766	(+1 -1 lines)

[ Permalink | « Hide ]

Nicolas Connault added a comment - 24/Jul/08 08:49 PM

This should solve it. Please confirm, Eloy.

Nicolas Connault made changes - 24/Jul/08 08:49 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
QA Assignee		stronk7

[ Permalink | « Hide ]

Petr Skoda added a comment - 29/Jul/08 02:59 PM

I think this is not correct:
function signup_captcha_enabled() { global $CFG; return isset($CFG->recaptchapublickey) && isset($CFG->recaptchaprivatekey) && get_config('auth/email', 'recaptcha'); }

there should be !empty() because there is empty string in it