Issue Details (XML | Word | Printable)

Key: MDL-15768
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Penny Leach
Reporter: Penny Leach
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14591

review roles usage in portfolio

Created: 22/Jul/08 09:14 PM   Updated: 03/Sep/08 12:28 AM
Return to search
Component/s: Portfolio API
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Penny Leach
Security Level: None
Resolved date: 03/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
might be just as simple as require_cap in portfolio/add.php

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Penny Leach added a comment - 23/Jul/08 05:56 PM
after discussion with MD the plan is to:
  • the calling code can check has_capability before calling portfolio_add_button
  • add a new method in the caller class to check permissions
  • name the capabilities consistently, eg mod/forum:export-post, mod/forum:export-attachment
  • figure out a way to disable (or enable) plugin instances per role.

[ Permalink | « Hide ]
Penny Leach added a comment - 23/Jul/08 05:57 PM
MD said:
10:53 <moodler_> hmm plugins, we did something similar for grade import/expot
(relating to fourth point above)

mjollnir_ committed 4 files to 'Moodle CVS' - 11/Aug/08 09:45 PM
 MDL-15768 - add new capabilities to mod/data for portfolio export
MODIFY mod/data/version.php   Rev. 1.36    (+2 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.191    (+2 -3 lines)
MODIFY mod/data/db/access.php   Rev. 1.19    (+38 -1 lines)
MODIFY lang/en_utf8/data.php   Rev. 1.76    (+4 -1 lines)
mjollnir_ committed 2 files to 'Moodle CVS' - 11/Aug/08 10:14 PM
MDL-15768 - further capability check in mod/data portfolio export
MODIFY mod/data/export.php   Rev. 1.8    (+2 -2 lines)
MODIFY mod/data/export_form.php   Rev. 1.7    (+6 -3 lines)
mjollnir_ committed 1 file to 'Moodle CVS' - 11/Aug/08 10:44 PM
MDL-15768 - bump mod/data version and requires properly - requires portfolio code
MODIFY mod/data/version.php   Rev. 1.37    (+3 -3 lines)
mjollnir_ committed 4 files to 'Moodle CVS' - 11/Aug/08 10:53 PM
 MDL-15768 - add capability check in mod/resource for portfolio export
MODIFY lang/en_utf8/resource.php   Rev. 1.15    (+2 -1 lines)
MODIFY mod/resource/version.php   Rev. 1.38    (+3 -3 lines)
MODIFY mod/resource/lib.php   Rev. 1.94    (+5 -3 lines)
MODIFY mod/resource/db/access.php   Rev. 1.6    (+3 -6 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 11/Aug/08 11:05 PM
MDL-15768 translated new strings for portfolio export.
MODIFY ja_utf8/data.php   Rev. 1.98    (+5 -1 lines)
MODIFY ja_utf8/resource.php   Rev. 1.33    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.783    (+1 -1 lines)
MODIFY ja_utf8/portfolio.php   Rev. 1.9    (+1 -2 lines)
mjollnir_ committed 6 files to 'Moodle CVS' - 11/Aug/08 11:31 PM
MDL-15768 - mod/assignment upgraded to check caps before portfolio export
MODIFY mod/assignment/lib.php   Rev. 1.344    (+5 -4 lines)
MODIFY lang/en_utf8/assignment.php   Rev. 1.28    (+2 -1 lines)
MODIFY mod/assignment/db/access.php   Rev. 1.9    (+13 -1 lines)
MODIFY mod/assignment/version.php   Rev. 1.60    (+3 -3 lines)
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.61    (+2 -2 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.54    (+3 -3 lines)
mjollnir_ committed 2 files to 'Moodle CVS' - 11/Aug/08 11:43 PM
MDL-15768 - more cap checks in resource mod
MODIFY mod/resource/type/text/Attic/resource.class.php   Rev. 1.42    (+4 -4 lines)
MODIFY mod/resource/type/html/Attic/resource.class.php   Rev. 1.47    (+4 -4 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 12/Aug/08 06:58 AM
MDL-15768 Translated a new string for assignment.
MDL-14492 Translated a new string for scorm.
MODIFY ja_utf8/scorm.php   Rev. 1.31    (+2 -1 lines)
MODIFY ja_utf8/assignment.php   Rev. 1.36    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 12/Aug/08 08:14 PM
MDL-15768 New capabilities translated
MODIFY fr_utf8/data.php   Rev. 1.75    (+4 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 12/Aug/08 08:15 PM
MDL-15768 More caps added
MODIFY fr_utf8/resource.php   Rev. 1.14    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 12/Aug/08 08:16 PM
MDL-15768 Assignment cap translated
MODIFY fr_utf8/assignment.php   Rev. 1.40    (+2 -1 lines)
mjollnir_ committed 4 files to 'Moodle CVS' - 12/Aug/08 09:31 PM
 MDL-15768 - added general capability for exporting any content to portfolio
MODIFY user/tabs.php   Rev. 1.59    (+2 -3 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.63    (+2 -1 lines)
MODIFY lib/db/access.php   Rev. 1.88    (+12 -0 lines)
MODIFY version.php   Rev. 1.762    (+1 -1 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 13/Aug/08 05:35 AM
MDL-15777 Translated new strings for portfolio.
MDL-15768 Translated a new string for role.
MODIFY ja_utf8/portfolio.php   Rev. 1.10    (+5 -3 lines)
MODIFY ja_utf8/README   Rev. 1.784    (+1 -1 lines)
MODIFY ja_utf8/role.php   Rev. 1.69    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 16/Aug/08 04:05 PM
MDL-15768 one more string
MODIFY fr_utf8/role.php   Rev. 1.84    (+2 -1 lines)
mjollnir_ committed 4 files to 'Moodle CVS' - 19/Aug/08 02:31 AM
MDL-15758 and MDL-15768

- updated forum portfolio code to use files api and added forum export caps.
MODIFY mod/forum/version.php   Rev. 1.78    (+2 -2 lines)
MODIFY mod/forum/lib.php   Rev. 1.710    (+46 -38 lines)
MODIFY lang/en_utf8/forum.php   Rev. 1.44    (+4 -1 lines)
MODIFY mod/forum/db/access.php   Rev. 1.17    (+39 -2 lines)
mjollnir_ committed 5 files to 'Moodle CVS' - 19/Aug/08 05:20 PM
MDL-15768 - roles in glossary
MODIFY mod/glossary/db/access.php   Rev. 1.11    (+25 -0 lines)
MODIFY lang/en_utf8/glossary.php   Rev. 1.15    (+3 -1 lines)
MODIFY mod/glossary/lib.php   Rev. 1.224    (+8 -14 lines)
MODIFY mod/glossary/version.php   Rev. 1.64    (+2 -2 lines)
MODIFY mod/glossary/export.php   Rev. 1.39    (+3 -2 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 20/Aug/08 01:56 AM
MDL-15768 Translated new strings for gloassary.
MDL-16047 Updated a translated string for portfolio based on lang/en_utf8 fix.
MDL-15666 MDL-16048 MDL-16124 MDL-16134 Translated new strings for portfolio.
MDL-13766 Translated new strings for repository.
MODIFY ja_utf8/portfolio.php   Rev. 1.14    (+12 -2 lines)
MODIFY ja_utf8/glossary.php   Rev. 1.43    (+3 -1 lines)
MODIFY ja_utf8/repository.php   Rev. 1.6    (+4 -1 lines)
MODIFY ja_utf8/README   Rev. 1.791    (+1 -1 lines)
mjollnir_ committed 1 file to 'Moodle CVS' - 23/Aug/08 12:34 AM
 MDL-15768 - fix forum permission checking for portfolio export
MODIFY mod/forum/lib.php   Rev. 1.715    (+8 -3 lines)
mjollnir_ committed 1 file to 'Moodle CVS' - 23/Aug/08 12:35 AM
 MDL-15768 - set userobject in the caller before checking permissions.
MODIFY portfolio/add.php   Rev. 1.16    (+1 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 27/Aug/08 04:40 PM
MDL-15768 forum export caps
MODIFY fr_utf8/forum.php   Rev. 1.53    (+4 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 27/Aug/08 04:44 PM
MDL-15768 Glossary export caps
MODIFY fr_utf8/glossary.php   Rev. 1.18    (+15 -13 lines)
[ Permalink | « Hide ]
Penny Leach added a comment - 03/Sep/08 12:28 AM
closing this issue as resolved.

the outstanding thing about trying to figure out a way to enable or disable instances per role is trickier and not necessarily needed right now so i will open a separate bug for it.


Penny Leach made changes - 03/Sep/08 12:28 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
mjollnir_ committed 1 file to 'Moodle CVS' - 09/Sep/08 05:10 PM
MDL-15768 - fixing missing cap check in export whole forum discussion
MODIFY mod/forum/discuss.php   Rev. 1.130    (+1 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators