Issue Details (XML | Word | Printable)

Key: MDL-15777
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Penny Leach
Reporter: Penny Leach
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14591

fix placeholders for file api stuff

Created: 22/Jul/08 11:25 PM   Updated: 16/Sep/08 11:49 PM
Return to search
Component/s: Files API, Portfolio API
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Penny Leach and Petr Skoda
Security Level: None
Resolved date: 16/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Currently the download plugin, boxnet plugin, and base library are all using old file api functions.

the plugins are marked by @todos and the function names in the base libarary are prefixed by temp_

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
mjollnir_ committed 8 files to 'Moodle CVS' - 06/Aug/08 11:27 PM
MDL-15777 - move all portfolio storage to portfolio_tempdata rather than session.
This allows us to always have a unique id for a portfolio export which can be used as itemid for files api.
Also it makes the session smaller :)
MODIFY portfolio/add.php   Rev. 1.7    (+19 -14 lines)
MODIFY mod/data/lib.php   Rev. 1.188    (+8 -8 lines)
MODIFY version.php   Rev. 1.754    (+1 -1 lines)
MODIFY lib/portfoliolib.php   Rev. 1.19    (+73 -41 lines)
MODIFY mod/glossary/lib.php   Rev. 1.218    (+15 -18 lines)
MODIFY lib/db/upgrade.php   Rev. 1.224    (+16 -1 lines)
MODIFY lang/en_utf8/portfolio.php   Rev. 1.8    (+1 -0 lines)
MODIFY lib/db/install.xml   Rev. 1.162    (+5 -4 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 07/Aug/08 01:55 PM
MDL-15777 Translated a new string for portfolio.
MODIFY ja_utf8/portfolio.php   Rev. 1.8    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.778    (+1 -1 lines)
mjollnir_ committed 13 files to 'Moodle CVS' - 09/Aug/08 10:24 PM
MDL-15777 - updated most of the portfolio code to use files api.

Not done:

- forum (the rest of the module isn't using files api yet)
- database mod (touches other parts of the code (ods and excel libs)
- portfolio download plugin (needs discussion with petr about userfiles)

all of these have been disabled in the meantime.
MODIFY mod/forum/lib.php   Rev. 1.700    (+7 -6 lines)
MODIFY mod/resource/type/html/Attic/resource.class.php   Rev. 1.46    (+3 -3 lines)
MODIFY mod/resource/lib.php   Rev. 1.93    (+7 -10 lines)
MODIFY mod/assignment/lib.php   Rev. 1.343    (+20 -19 lines)
MODIFY mod/data/export_form.php   Rev. 1.5    (+11 -6 lines)
MODIFY portfolio/add.php   Rev. 1.8    (+11 -11 lines)
MODIFY mod/glossary/lib.php   Rev. 1.219    (+7 -14 lines)
MODIFY portfolio/type/boxnet/Attic/lib.php   Rev. 1.7    (+8 -6 lines)
MODIFY portfolio/type/download/Attic/lib.php   Rev. 1.4    (+5 -1 lines)
MODIFY lib/portfoliolib.php   Rev. 1.20    (+100 -48 lines)
MODIFY mod/resource/type/text/Attic/resource.class.php   Rev. 1.41    (+3 -3 lines)
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.60    (+3 -6 lines)
MODIFY mod/data/lib.php   Rev. 1.189    (+2 -2 lines)
mjollnir_ committed 5 files to 'Moodle CVS' - 11/Aug/08 06:40 PM
MDL-15777 - whole database module export rejigged to use files api.

disabled ods and excel export for now until those libraries work with files api.
reverted a previous patch I had in this area.
MODIFY mod/data/export_form.php   Rev. 1.6    (+3 -3 lines)
MODIFY lang/en_utf8/data.php   Rev. 1.75    (+2 -1 lines)
MODIFY mod/data/lib.php   Rev. 1.190    (+19 -32 lines)
MODIFY lang/en_utf8/portfolio.php   Rev. 1.9    (+0 -1 lines)
MODIFY mod/data/export.php   Rev. 1.7    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 12/Aug/08 04:24 AM
MDL-15777, string added
MODIFY fr_utf8/portfolio.php   Rev. 1.4    (+2 -1 lines)
martignoni committed 2 files to 'Lang CVS' - 12/Aug/08 08:09 PM
MDL-15777 string moved
MODIFY fr_utf8/data.php   Rev. 1.74    (+2 -1 lines)
MODIFY fr_utf8/portfolio.php   Rev. 1.5    (+1 -2 lines)
mjollnir_ committed 6 files to 'Moodle CVS' - 12/Aug/08 09:17 PM
MDL-15777 more fixes for portfolio to use file api

this introduces portfolio/file.php to serve portfolio related files - access check is delegated to the plugin.
and also two new classes in the portfolio plugin tree - push vs pull.
MODIFY portfolio/type/download/Attic/lib.php   Rev. 1.5    (+22 -22 lines)
MODIFY portfolio/add.php   Rev. 1.9    (+0 -11 lines)
MODIFY lang/en_utf8/portfolio.php   Rev. 1.10    (+4 -2 lines)
ADD portfolio/file.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/portfoliolib.php   Rev. 1.22    (+58 -20 lines)
MODIFY portfolio/type/boxnet/Attic/lib.php   Rev. 1.10    (+1 -1 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 13/Aug/08 05:35 AM
MDL-15777 Translated new strings for portfolio.
MDL-15768 Translated a new string for role.
MODIFY ja_utf8/role.php   Rev. 1.69    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.784    (+1 -1 lines)
MODIFY ja_utf8/portfolio.php   Rev. 1.10    (+5 -3 lines)
martignoni committed 1 file to 'Lang CVS' - 16/Aug/08 04:04 PM
MDL-15777, more strings
MODIFY fr_utf8/portfolio.php   Rev. 1.6    (+5 -3 lines)
mjollnir_ committed 1 file to 'Moodle CVS' - 05/Sep/08 08:42 PM
MDL-15777 - better handling of integration with file api in portfolio mahara plugin
MODIFY portfolio/type/mahara/Attic/lib.php   Rev. 1.9    (+6 -2 lines)
mjollnir_ committed 3 files to 'Moodle CVS' - 16/Sep/08 11:48 PM
MDL-15777 - updated data file and picture field types to export files using file api.

There's still something about this I don't like - documented in MDL-16493 and code
MODIFY mod/data/field/file/field.class.php   Rev. 1.28    (+17 -3 lines)
MODIFY mod/data/lib.php   Rev. 1.202    (+39 -10 lines)
MODIFY mod/data/field/picture/field.class.php   Rev. 1.30    (+18 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators