Moodle

"Add blocks" block now slightly broken :(

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.3
  • Component/s: Blocks
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The patch for MDL-15501 was erroneous.

You wrote (in blocklib.php, blocks_print_adminblock(), lines 952+)
+ $strblocks = '<div class="title"><h2>';
+ $strblocks .= get_string('blocks');
+ $strblocks .= '</h2>';

whereas it should be
+ $strblocks = '<div class="title"><h2>';
+ $strblocks .= get_string('blocks');
+ $strblocks .= '</h2></div>';

Activity

Hide
Herbert Thielen added a comment -

This is also affecting moodle version 1.8.6 and 1.8.7.

Annoyingly, it breaks the editing mode for courses with "Weeky format - CSS/no tables"; then the whole middle column is empty, and the course content is added to the right content - below the visible screen if you don't scroll, so one can imagine it's lost.

Show
Herbert Thielen added a comment - This is also affecting moodle version 1.8.6 and 1.8.7. Annoyingly, it breaks the editing mode for courses with "Weeky format - CSS/no tables"; then the whole middle column is empty, and the course content is added to the right content - below the visible screen if you don't scroll, so one can imagine it's lost.
Show
Tim Hunt added a comment - This was fixed in Moodle 1.9.3. See http://cvs.moodle.org/moodle/lib/blocklib.php?r1=1.129.2.3&r2=1.129.2.4&pathrev=MOODLE_19_STABLE
Hide
Jerome Mouneyrac added a comment -

I checked on 1.9, the generated HTML code is correct.
Thanks for your participation.

Show
Jerome Mouneyrac added a comment - I checked on 1.9, the generated HTML code is correct. Thanks for your participation.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: