Issue Details (XML | Word | Printable)

Key: MDL-15792
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Yolanda Ordoñez Rufat
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Images in question don't display

Created: 23/Jul/08 04:18 PM   Updated: 13/Aug/08 09:00 AM
Return to search
Component/s: Quiz
Affects Version/s: 1.9.2
Fix Version/s: 1.9.3

Issue Links:
Duplicate
 

Participants: Petr Skoda, Tim Hunt and Yolanda Ordoñez Rufat
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 23/Jul/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
When you set an image in a question from the combo 'Image to display' (not in the html) the image is not displayed in the quiz.

If you set the debuging messages you'll get this notice:
    Notice: Undefined variable: courseid in /www/moodle/lib/questionlib.php on line 1508

There's an error in the function get_question_image($question) from the moodle/lib/questionlib.php

The solution:
around line 1508
    $img = get_file_url("$courseid/{$question->image}");
should be
    $img = get_file_url("$coursefilesdir/{$question->image}");

So just need to change $courseid to $coursefilesdir

We test the solution on a 1.9.2 moodle with a 8.2.4 postgres installed in a SUSE Linux Enterprise Server 10 SP1



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 23/Jul/08 06:32 PM
MDL-15792 - Images in question don't display. This is a regression from MDL-14279. Fix thanks to Yolanda Ord��ez Rufat.
MODIFY lib/questionlib.php   Rev. 1.119.2.15    (+2 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 23/Jul/08 06:32 PM
MDL-15792 - Images in question don't display. This is a regression from MDL-14279. Fix thanks to Yolanda Ord��ez Rufat.
MODIFY lib/questionlib.php   Rev. 1.151    (+2 -2 lines)
Tim Hunt added a comment - 23/Jul/08 06:32 PM
This is a regression from MDL-14279. Thanks for the fix.

Tim Hunt made changes - 23/Jul/08 06:32 PM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.9.3 [ 10290 ]
Tim Hunt made changes - 28/Jul/08 10:21 PM
Link This issue is duplicated by MDL-15862 [ MDL-15862 ]
Petr Skoda added a comment - 29/Jul/08 03:01 PM
thanks, closing

Petr Skoda made changes - 29/Jul/08 03:01 PM
QA Assignee skodak
Status Resolved [ 5 ] Closed [ 6 ]
Tim Hunt made changes - 29/Jul/08 05:27 PM
Link This issue is duplicated by MDL-15868 [ MDL-15868 ]
Tim Hunt made changes - 04/Aug/08 09:07 PM
Link This issue is duplicated by MDL-15927 [ MDL-15927 ]
Tim Hunt made changes - 13/Aug/08 09:00 AM
Link This issue is duplicated by MDL-16014 [ MDL-16014 ]