|
[
Permalink
| « Hide
]
Jenny Gray added a comment - 23/Jul/08 08:30 PM
Attaching this to the GSoc Usability issues work as something they might want to pick up.
I have created a patch for this issue.
File changed is lib/pear/HTML/QuickForm/Renderer/Tableless.php Hi,
Thanks for the patch. In general we have avoided modifying the pear code itself and confined our modifications to classes that subclass the pear classes. I attach another patch which modifies lib/formslib.php instead of the pear files. But still there is a problem with this patch. I don't know why this is being done : + $requiredNote = $form->getRequiredNote(); If you want to change the default html for the required note we should modify the form class in lib/formslib.php where it is set in the constructor. OK I quite understand about not wanting to change the pear libraries, that makes a lot of sense. Your patch is better.
The reason for the HTML mangling is simply that that's what the pear code does. Take a look at function finishForm in the Tableless.php file. James' patch is just a direct copy. Though why they want to do that is a mystery! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||