Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.0
-
Component/s: Database SQL/XMLDB
-
Labels:None
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_20_STABLE
Description
In order to fully support backwards compatibility with the new moodle_recordset objects, we must change the implementation of key (as mandated by the Iterator interface) to return the first column of the current row. Currently it is returning the rowcount.
This means that
$records = $DB->get_records('foo'); and $records[$someid] do not behave as they used to.
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Err..
but $foo[$presetidweexpect] doesn't.
What's $foo there? One recordset (get_recordset_xxx) or one record array (get_record_xxx)?
If recordset, it cannot be accessed as array at all! It's an (forward) iterator! Born to iterate! 
The only change I think we can make is to, effectively, return proper keys with 1st field in current record, in order to allow:
foreach ($recordset as $key => $record) {
}
iterations to be used. Instead of current "order" (record counter).
I'll post here one patch for adodb and pdo iterator implementations in order to provide that $key properly.
Ciao 
The only change I think we can make is to, effectively, return proper keys with 1st field in current record, in order to allow:
foreach ($recordset as $key => $record) {
}
iterations to be used. Instead of current "order" (record counter).
I'll post here one patch for adodb and pdo iterator implementations in order to provide that $key properly.
Ciao Ah, just rereading:
"next is implemented (what is making foreach($DB->get_records('foo')) "
That's incorrect! get_recordsXXX() is able to iterate because it's one array. No iterator there at all.
Only get_recordsetXXX() are able to iterate (sequentially forward to be cross-db) because we have one iterator for them.
Ciao
Committed with some functional tests.
Resolving as fixed. Ciao
oopps!