Moodle

better error checking in box.net plugin

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Portfolio API
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

timeouts are causing brokenness. investigate fixing the boxnet class (in box.net repo plugin) to deal with timeouts and report errors more gracefully.

Activity

Hide
Penny Leach added a comment -

dongsheng - I'm adding you as a watcher because I think this affects you too.

Show
Penny Leach added a comment - dongsheng - I'm adding you as a watcher because I think this affects you too.
Hide
Dongsheng Cai added a comment -

Penny, these is no callback function option for curl timeout, so I assume it is time-out if no return value from curl_exec, a moodle_exception will be thrown, does this make sense?

Show
Dongsheng Cai added a comment - Penny, these is no callback function option for curl timeout, so I assume it is time-out if no return value from curl_exec, a moodle_exception will be thrown, does this make sense?
Hide
Penny Leach added a comment -

fine. I think it should be caught in the boxlib class though and the error status set there, rather than falling through to whatever is calling boxlib functions.

Show
Penny Leach added a comment - fine. I think it should be caught in the boxlib class though and the error status set there, rather than falling through to whatever is calling boxlib functions.
Hide
Penny Leach added a comment -

closing. DS added extra stuff in the boxnet client class.

Show
Penny Leach added a comment - closing. DS added extra stuff in the boxnet client class.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: