|
Chris Fryer made changes - 01/Aug/08 06:20 PM
Iñaki Arenaza made changes - 03/Aug/08 11:48 PM
(Added Petr Skodak as a watcher, so he can give his opinion on this)
Chris, I think the bug appears in this commit: http://cvs.moodle.org/moodle/enrol/imsenterprise/enrol.php?r1=1.8&r2=1.8.6.1&pathrev=MOODLE_18_STABLE Instead of chaning the authentication value, we changed the language value. So I'd say that commit should have read like this: $person->lang = $CFG->lang; Of course, that imposes 'manual' authentication to all users created by the IMS Enrolment plugin, which may or may not be a good idea. This is exactly where I'd like Petr to share his opinion on the issue. Should we hardcode 'manual' or should we have a configurable value like Chris' patch allows? I'd favor the latter, but I'd like to have a second opinion on this. Saludos. Iñaki.
Chris Fryer made changes - 05/Aug/08 06:05 PM
> Of course, that imposes 'manual' authentication to all users created
> by the IMS Enrolment plugin, which may or may not be a good idea. I've linked this to a related issue, which may help you decide. It's possible to specify a password in a "person" object in IMS Enterprise. In that case, it would make sense to set the auth type to manual. I think it's better to allow administrators to choose an authentication method for users who don't have a password in the IMS document. There is a conflict between the patches in each issue. MDL-15864 has if (!isset($person->auth)) $person->auth = $CFG->auth while MDL-15863 (this bug) has if(!isset($person->auth)) $person->auth = $CFG->enrol_imse_defaultauth; Not difficult to resolve, but I thought I'd let you know in case you decide to incorporate the patches into the core.
Chris Fryer made changes - 04/Sep/08 07:03 PM
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Seems to work. I'd appreciate some feedback.