Moodle

Defaults broken in admin_setting_configmulticheckbox::output_html

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

This code (used eg for selecting roles in gradebook, and now in completion system too) had some minor logical errors. It was filling a $current array which was then never used. This caused defaults not to work/display correctly when displaying these lists.

Activity

Hide
Sam Marshall added a comment -

OK, fixed in HEAD only.

Show
Sam Marshall added a comment - OK, fixed in HEAD only.
Hide
Petr Škoda (skodak) added a comment -

the problem was not in defaults, but in the refactored code - reverting the incorrect change of logic there and fixing...

Show
Petr Škoda (skodak) added a comment - the problem was not in defaults, but in the refactored code - reverting the incorrect change of logic there and fixing...
Hide
Petr Škoda (skodak) added a comment -

hmm, this is more difficult than I expected
there is also a problem in settings and search page because it uses defaults when settings missing, but only upgradesettings should do this

testing a patch, now I see that your approach was better than what we had before, though there were still some minor problems

Show
Petr Škoda (skodak) added a comment - hmm, this is more difficult than I expected there is also a problem in settings and search page because it uses defaults when settings missing, but only upgradesettings should do this testing a patch, now I see that your approach was better than what we had before, though there were still some minor problems
Hide
Petr Škoda (skodak) added a comment -

I will have to file a new bug from 1.9 defaults too

Show
Petr Škoda (skodak) added a comment - I will have to file a new bug from 1.9 defaults too
Hide
Petr Škoda (skodak) added a comment -

reclosing, thanks Sam

Show
Petr Škoda (skodak) added a comment - reclosing, thanks Sam
Hide
Petr Škoda (skodak) added a comment -

reopening, still some probs there, testing patch

Show
Petr Škoda (skodak) added a comment - reopening, still some probs there, testing patch
Hide
Petr Škoda (skodak) added a comment -

I hope now it is on

Show
Petr Škoda (skodak) added a comment - I hope now it is on

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: