Issue Details (XML | Word | Printable)

Key: MDL-15876
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Sam Marshall
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Defaults broken in admin_setting_configmulticheckbox::output_html

Created: 29/Jul/08 10:26 PM   Updated: 28/Aug/08 03:08 PM
Return to search
Component/s: Administration
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Petr Skoda and Sam Marshall
Security Level: None
Resolved date: 28/Aug/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
This code (used eg for selecting roles in gradebook, and now in completion system too) had some minor logical errors. It was filling a $current array which was then never used. This caused defaults not to work/display correctly when displaying these lists.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
sam_marshall committed 1 file to 'Moodle CVS' - 29/Jul/08 10:26 PM
MDL-15876: Fixed error with defaults in config_multicheckbox
MODIFY lib/adminlib.php   Rev. 1.230    (+4 -4 lines)
[ Permalink | « Hide ]
Sam Marshall added a comment - 29/Jul/08 10:27 PM
OK, fixed in HEAD only.

Sam Marshall made changes - 29/Jul/08 10:27 PM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.0 [ 10122 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 13/Aug/08 06:13 AM
the problem was not in defaults, but in the refactored code - reverting the incorrect change of logic there and fixing...

Petr Skoda made changes - 13/Aug/08 06:13 AM
Resolution Fixed [ 1 ]
Assignee Sam Marshall [ quen ] Petr Skoda [ skodak ]
Status Resolved [ 5 ] Reopened [ 4 ]
Petr Skoda made changes - 13/Aug/08 06:13 AM
Priority Minor [ 4 ] Major [ 3 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 13/Aug/08 06:52 AM
hmm, this is more difficult than I expected
there is also a problem in settings and search page because it uses defaults when settings missing, but only upgradesettings should do this

testing a patch, now I see that your approach was better than what we had before, though there were still some minor problems


[ Permalink | « Hide ]
Petr Skoda added a comment - 13/Aug/08 06:53 AM
I will have to file a new bug from 1.9 defaults too

[ Permalink | « Hide ]
Petr Skoda added a comment - 18/Aug/08 06:50 AM
reclosing, thanks Sam

Petr Skoda made changes - 18/Aug/08 06:50 AM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 28/Aug/08 03:05 PM
reopening, still some probs there, testing patch

Petr Skoda made changes - 28/Aug/08 03:05 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Petr Skoda committed 2 files to 'Moodle CVS' - 28/Aug/08 03:08 PM
MDL-15876 I hope the multicheckbox now works 100% :-)
MODIFY lib/adminlib.php   Rev. 1.250    (+15 -10 lines)
MODIFY admin/index.php   Rev. 1.337    (+5 -5 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 28/Aug/08 03:08 PM
I hope now it is on

Petr Skoda made changes - 28/Aug/08 03:08 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators