Moodle

Some DB implementation things

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Files API
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Some things I found when looking to DB:

  • contenthash VARCHAR(40)... seems to be nullable. Is that correct?
  • itemid BIGINT(10) unsigned ... also is nullable. Aren't all files going to have itemid?
  • status BIGINT(10) ... stands for?
  • CREATE INDEX mdl_file_con_ix ON mdl_files (contenthash) , shouldn't this be unique too?
  • CREATE INDEX mdl_file_con2_ix ON mdl_files (contextid) , doesn't seem to be necessary as there is another index with "contextid" as first field.
  • CREATE INDEX mdl_fileclea_con_ix ON mdl_files_cleanup (contenthash) , if index above (by contexthash) is unique, this should be too.

Activity

Hide
Petr Škoda (skodak) added a comment -

status is some error status - virus found, file missing, etc. 0 means file ok - not implemented yet

Show
Petr Škoda (skodak) added a comment - status is some error status - virus found, file missing, etc. 0 means file ok - not implemented yet
Hide
Petr Škoda (skodak) added a comment -

patch updated, sending soon

Show
Petr Škoda (skodak) added a comment - patch updated, sending soon
Hide
Petr Škoda (skodak) added a comment -

done, thanks

Show
Petr Škoda (skodak) added a comment - done, thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: