|
|
| Participants: |
Eloy Lafuente (stronk7) and Petr Skoda
|
| Security Level: |
None
|
| Resolved date: |
01/Aug/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
|
Some things I found when looking to DB:
- contenthash VARCHAR(40)... seems to be nullable. Is that correct?
- itemid BIGINT(10) unsigned ... also is nullable. Aren't all files going to have itemid?
- status BIGINT(10) ... stands for?
- CREATE INDEX mdl_file_con_ix ON mdl_files (contenthash) , shouldn't this be unique too?
- CREATE INDEX mdl_file_con2_ix ON mdl_files (contextid) , doesn't seem to be necessary as there is another index with "contextid" as first field.
- CREATE INDEX mdl_fileclea_con_ix ON mdl_files_cleanup (contenthash) , if index above (by contexthash) is unique, this should be too.
|
|
Description
|
Some things I found when looking to DB:
- contenthash VARCHAR(40)... seems to be nullable. Is that correct?
- itemid BIGINT(10) unsigned ... also is nullable. Aren't all files going to have itemid?
- status BIGINT(10) ... stands for?
- CREATE INDEX mdl_file_con_ix ON mdl_files (contenthash) , shouldn't this be unique too?
- CREATE INDEX mdl_file_con2_ix ON mdl_files (contextid) , doesn't seem to be necessary as there is another index with "contextid" as first field.
- CREATE INDEX mdl_fileclea_con_ix ON mdl_files_cleanup (contenthash) , if index above (by contexthash) is unique, this should be too.
|
Show » |
made changes - 01/Aug/08 06:15 AM
| Field |
Original Value |
New Value |
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Sub-task
Resolved
Minor
