[#MDL-15890] public method modifier appeared in Moodle 1.9

Issue Details (XML | Word | Printable)

Key:	MDL-15890
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Critical
Assignee:	Petr Skoda
Reporter:	Howard Miller
Votes:	1
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

public method modifier appeared in Moodle 1.9

Created: 31/Jul/08 02:44 AM Updated: 12/Aug/08 01:05 PM

Return to search

Component/s:

Administration

Affects Version/s:

1.9.2

Fix Version/s:

1.9.3

Issue Links:

Duplicate

This issue is duplicated by:

~~MDL-15917~~ fuction public in adminlib, no install in php4

~~MDL-15889~~ Parse error on adminlib.php

Participants:	Eloy Lafuente (stronk7), Howard Miller and Petr Skoda
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	31/Jul/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

In lib/adminlib.php

this (at line 3517ish)...

/**
* Enrolment manage page
*/
class admin_enrolment_page extends admin_externalpage {
public function admin_enrolment_page() {
global $CFG;
parent::admin_externalpage('enrolment', get_string('enrolments'),
$CFG->wwwroot . '/'.$CFG->admin.'/enrol.php');
}

That will break on PHP4. We haven't gone to PHP5 for 1.9 have we?

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Howard Miller added a comment - 31/Jul/08 02:45 AM

Adding Petr, and noting where this turned up...

http://moodle.org/mod/forum/discuss.php?d=102377

[ Permalink | « Hide ]

Petr Skoda added a comment - 31/Jul/08 03:24 AM

oops, fixing ASAP

[ Permalink | « Hide ]

Petr Skoda added a comment - 31/Jul/08 03:26 AM

fixed, sorry

[ Permalink | « Hide ]

Petr Skoda added a comment - 31/Jul/08 04:00 AM

to Richard: patch is available from the "Version Control" tab above

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 31/Jul/08 06:37 PM

I've moved the MOODLE_19_WEEKLY tag to Revision 1.153.2.51 for that file in order to be able to get it from normal cvs update -dPr MOODLE_19_WEEKLY commands.

Ciao

All content on this web site is made available under the GNU General Public License, unless otherwise stated.