Moodle

param cleaning improvements

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: General
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

PARAM_ALPHAEXT - no "/" anymore
PARAM_SAFEPATH - replaces PARAM_ALPHAEXT when "/" needed
PARAM_ALPHANUMEXT

PARAM_TAG - block "<>"and control chars and allow "\"

PARAM_PLAINTEXT like PARAM_TEXT but without multilang support (wiki page names, etc.)

Issue Links

This issue caused a regression:
MDL-29535 borked context filter settings after change in PARAM_ALPHAEXT Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

not sure about PARAM_PLAINTEXT anymore - PARAM_NOTAGS seems like a good candidate instead.

Anyway there is a lot to improve in this area

Show
Petr Škoda (skodak) added a comment - not sure about PARAM_PLAINTEXT anymore - PARAM_NOTAGS seems like a good candidate instead. Anyway there is a lot to improve in this area
Hide
Permalink
Petr Škoda (skodak) added a comment -

also adding is_number() for integers including string form; aliasing PRAM_NUMBER to PARAM_FLOAT and deprecating

Show
Petr Škoda (skodak) added a comment - also adding is_number() for integers including string form; aliasing PRAM_NUMBER to PARAM_FLOAT and deprecating
Hide
Permalink
Martin Dougiamas added a comment -

I tidied up PARAM_XXXX defines to use strings instead of octal numbers, sort alphabetically and segregate the aliases and deprecated definitions.

Also added new definitions for PARAM_AUTH, PARAM_LANG and PARAM_THEME

Show
Martin Dougiamas added a comment - I tidied up PARAM_XXXX defines to use strings instead of octal numbers, sort alphabetically and segregate the aliases and deprecated definitions. Also added new definitions for PARAM_AUTH, PARAM_LANG and PARAM_THEME
Hide
Permalink
Ashley Holman added a comment -

I had to update the admin_setting_configtext validation check because it was assuming these constants were integers and treating all strings are regex patterns. The check now requires the regex patterns to be surrounded by slashes, otherwise will treat it as a PARAM constant.

Show
Ashley Holman added a comment - I had to update the admin_setting_configtext validation check because it was assuming these constants were integers and treating all strings are regex patterns. The check now requires the regex patterns to be surrounded by slashes, otherwise will treat it as a PARAM constant.
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks for the fix, closing as fixed

Petr Skoda

Show
Petr Škoda (skodak) added a comment - thanks for the fix, closing as fixed Petr Skoda

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.