[#MDL-15897] param cleaning improvements

Issue Details (XML | Word | Printable)

Key:	MDL-15897
Type:	Improvement
Status:	Open
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

param cleaning improvements

Created: 31/Jul/08 10:14 PM Updated: 18/Sep/09 11:53 AM

Return to search

Component/s:

General

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Ashley Holman, Martin Dougiamas and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

PARAM_ALPHAEXT - no "/" anymore
PARAM_SAFEPATH - replaces PARAM_ALPHAEXT when "/" needed
PARAM_ALPHANUMEXT

PARAM_TAG - block "<>"and control chars and allow "\"

PARAM_PLAINTEXT like PARAM_TEXT but without multilang support (wiki page names, etc.)

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 31/Jul/08 11:41 PM

not sure about PARAM_PLAINTEXT anymore - PARAM_NOTAGS seems like a good candidate instead.

Anyway there is a lot to improve in this area

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Aug/08 04:09 AM

also adding is_number() for integers including string form; aliasing PRAM_NUMBER to PARAM_FLOAT and deprecating

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 16/Sep/09 10:23 PM

I tidied up PARAM_XXXX defines to use strings instead of octal numbers, sort alphabetically and segregate the aliases and deprecated definitions.

Also added new definitions for PARAM_AUTH, PARAM_LANG and PARAM_THEME

[ Permalink | « Hide ]

Ashley Holman added a comment - 18/Sep/09 11:53 AM

I had to update the admin_setting_configtext validation check because it was assuming these constants were integers and treating all strings are regex patterns. The check now requires the regex patterns to be surrounded by slashes, otherwise will treat it as a PARAM constant.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.