|
OK - I have tested this, and the only problem that I can come up with so far under IE7 is that it doesn't like the use of spaces in the window.open() name parameter for the popup code. As a temporary fix, please try changing the name of your SCORM activity to a single word with no spaces eg. Sample2004 or Sample_2004. Try this and let me know how you go, in the meantime I will work on a proper fix.
Please, in future, add screen shots of browser/JavaScript problems as it helps gretly with the problem resolution. Thanks, thanks Piers - Patch looks good to me, go ahead and push to 18Stable and 19Stable
OK - this has been patched in HEAD, 1.9 STABLE and 1.8 STABLE - Andrea, please test this and let me know if there are any further problems.
Cheers, Thanks for so a fast fix. Just to be sure I'm testing correctly, when you say about Activity Name, you mean the Moodle SCORM activity name or the name of the SCORM packet as it appear on the file system ?
Yes - it is the Moodle SCORM activity name. If you able to test against the current 1.9 or 1.8 stable branches, then you do not need to change anything.
Cheers, Hi Piers, thanks for the clarification.
If I correctly understand, then the fix you committed will need to rename every already existing SCORM activities, in other words we are breaking what is in already in place and working prior to 20070730 weekly release. Not sure if it is a viable fix, reopening the issue. If I'm wrong, please let me know. Andrea Reopening, the fix need to rename every existing SCORM activity.
I suggested renaming your SCORM activities as an immediate solution to your problem, until I had provided a patch. That patch has now been commited in HEAD, 1.9 STABLE, and 1.8 STABLE, so if you check out one of these then there is no need to rename your activities.
Have you tried the updated software? Cheers, Thanks Piers! Tested the new patch and works fine. Resolving.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Critical
JavaScript error In IE7 when opening SCORM content in a new window
Dan  |
|
I'm pretty sure the code that would have caused this has been in HEAD for quite a while! - and we spent quite a bit of time testing it, - unfortunately looks like we missed this! - any chance you might be able to do some more testing for us before we commit stuff to stable trees?
Dan