Moodle

done except backup/restore

Reopening this because of some SQL cross-db annoyances (detected under PG)

Hi, while trying to upgrade to latest HEAD I'm getting this under PG:

ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function

SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment

Also, under MSSQL I get some errors.

Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement.

Important note: Both forum and glossary exhibit the same problem.

Ciao

thanks, fixed

Just tried this as a student and didn't get the file picker when submitting a file to the upload a single file assignment type. Is this deliberate (students don't get to use the file picker) or have I misconfigured it?

online assignment module needs file storage conversion.

1. Aparup is going to change this upgrade to store files with itemid == submission->id instead of userid.

This will break dev sites unfortunately so upgrade from 1.9 again. Again.

2. Yes, online assignment needs a filemanager element.

yes, the submission id is better there

See linked bugs

Linked bugs closed, closing, thanks!