Issue Details (XML | Word | Printable)

Key: MDL-15904
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14589

File storage conversion Assignment

Created: 01/Aug/08 06:07 AM   Updated: 19/Aug/08 06:27 AM
Return to search
Component/s: Assignment
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File assignment_upgrade.patch.txt (1 kB)

Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
Resolved date: 19/Aug/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 48 files to 'Moodle CVS' - 01/Aug/08 06:15 AM
MDL-14589 initial file storage implementation, temporary file manager, migration of course files; blog conversion MDL-15905; assignment conversion MDL-15904; fromslib related file improvements MDL-15906
MODIFY mod/assignment/upload.php   Rev. 1.30    (+2 -2 lines)
ADD lib/file/file_storage.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/editadvanced_form.php   Rev. 1.20    (+1 -2 lines)
ADD lib/file/file_info_coursecat.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/formslib.php   Rev. 1.149    (+229 -85 lines)
MODIFY group/lib.php   Rev. 1.18    (+6 -6 lines)
MODIFY files/index.php   Rev. 1.134    (+212 -829 lines)
MODIFY version.php   Rev. 1.744    (+1 -1 lines)
ADD draftfile.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/uploadpicture.php   Rev. 1.10    (+5 -5 lines)
ADD userfile.php   Rev. 1.1    (+0 -0 lines)
ADD lib/file/file_info_coursefile.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/editlib.php   Rev. 1.25    (+6 -4 lines)
MODIFY lib/db/install.xml   Rev. 1.159    (+41 -1 lines)
MODIFY file.php   Rev. 1.54    (+35 -118 lines)
ADD lib/file/file_info_system.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/edit_form.php   Rev. 1.28    (+1 -2 lines)
MODIFY lib/filelib.php   Rev. 1.76    (+189 -16 lines)
ADD lib/file/stored_file.php   Rev. 1.1    (+0 -0 lines)
ADD lib/file/file_info_user.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/editor/tinymce/Attic/coursefiles.php   Rev. 1.5    (+3 -1 lines)
ADD lib/file/Attic/file_packer.php   Rev. 1.1    (+0 -0 lines)
MODIFY blog/lib.php   Rev. 1.100    (+39 -55 lines)
MODIFY lib/weblib.php   Rev. 1.1119    (+3 -3 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.53    (+187 -191 lines)
MODIFY lib/db/upgrade.php   Rev. 1.219    (+87 -8 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.121    (+6 -1 lines)
MODIFY lib/db/access.php   Rev. 1.87    (+28 -0 lines)
MODIFY lib/moodlelib.php   Rev. 1.1082    (+43 -28 lines)
MODIFY lib/gdlib.php   Rev. 1.18    (+8 -9 lines)
MODIFY group/group_form.php   Rev. 1.8    (+1 -2 lines)
ADD lib/file/file_exceptions.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/roles/manage.php   Rev. 1.62    (+2 -2 lines)
MODIFY mod/assignment/lib.php   Rev. 1.341    (+84 -65 lines)
MODIFY group/group.php   Rev. 1.22    (+2 -2 lines)
MODIFY lib/editor/htmlarea/Attic/coursefiles.php   Rev. 1.21    (+3 -1 lines)
MODIFY mod/assignment/version.php   Rev. 1.59    (+2 -2 lines)
ADD lib/file/file_browser.php   Rev. 1.1    (+0 -0 lines)
MODIFY config-dist.php   Rev. 1.108    (+1 -8 lines)
MODIFY lib/db/upgradelib.php   Rev. 1.18    (+167 -2 lines)
MODIFY blog/edit.php   Rev. 1.68    (+15 -9 lines)
ADD pluginfile.php   Rev. 1.1    (+0 -0 lines)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.41    (+65 -72 lines)
MODIFY blog/edit_form.php   Rev. 1.16    (+1 -4 lines)
ADD lib/file/file_info.php   Rev. 1.1    (+0 -0 lines)
ADD lib/file/file_info_course.php   Rev. 1.1    (+0 -0 lines)
ADD lib/file/file_info_stored.php   Rev. 1.1    (+0 -0 lines)
MODIFY mod/assignment/db/upgrade.php   Rev. 1.18    (+119 -1 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 01/Aug/08 06:16 AM
done except backup/restore

Petr Skoda made changes - 01/Aug/08 06:16 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 16/Aug/08 09:32 PM
MDL-15904 fixed problem in interrupted assignment file migration
MODIFY mod/assignment/db/upgrade.php   Rev. 1.20    (+3 -3 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 17/Aug/08 02:13 AM
MDL-15904 oops - fixed assignment upgrade migration
MODIFY mod/assignment/db/upgrade.php   Rev. 1.22    (+13 -11 lines)
MODIFY mod/assignment/type/uploadsingle/assignment.class.php   Rev. 1.43    (+3 -1 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 17/Aug/08 02:24 AM
MDL-15904 simplified moddata cleanup
MODIFY mod/assignment/db/upgrade.php   Rev. 1.23    (+4 -24 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 17/Aug/08 03:12 AM
MDL-15904 incorrect use of count sql fixed
MODIFY mod/assignment/db/upgrade.php   Rev. 1.24    (+2 -2 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 17/Aug/08 08:04 PM
MDL-15904 fixed assignment reset
MODIFY mod/assignment/lib.php   Rev. 1.349    (+9 -3 lines)
MODIFY mod/assignment/lib.php   Rev. 1.350    (+4 -4 lines)
Petr Skoda committed 3 files to 'Moodle CVS' - 17/Aug/08 08:09 PM
MDL-15904 fixed assignment instance deleting
MODIFY mod/assignment/lib.php   Rev. 1.353    (+3 -3 lines)
MODIFY mod/assignment/lib.php   Rev. 1.352    (+1 -7 lines)
MODIFY mod/assignment/lib.php   Rev. 1.351    (+11 -1 lines)
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 18/Aug/08 11:26 PM
Reopening this because of some SQL cross-db annoyances (detected under PG)

Eloy Lafuente (stronk7) made changes - 18/Aug/08 11:26 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 18/Aug/08 11:29 PM
Hi, while trying to upgrade to latest HEAD I'm getting this under PG:

ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function

SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment

Also, under MSSQL I get some errors.

Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement.

Important note: Both forum and glossary exhibit the same problem.

Ciao


Eloy Lafuente (stronk7) made changes - 18/Aug/08 11:29 PM
Attachment assignment_upgrade.patch.txt [ 14875 ]
Petr Skoda committed 2 files to 'Moodle CVS' - 19/Aug/08 06:26 AM
MDL-15904 fixed pg problem
MODIFY mod/assignment/db/upgrade.php   Rev. 1.26    (+3 -4 lines)
MODIFY mod/assignment/version.php   Rev. 1.61    (+2 -2 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 19/Aug/08 06:27 AM
thanks, fixed

Petr Skoda made changes - 19/Aug/08 06:27 AM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Sam Hemelryk committed 3 files to 'Moodle CVS' - 20/Nov/09 02:57 PM
assignment MDL-15904 Converted final htmleditor elements and fixed a couple of VERY minor regressions
MODIFY mod/assignment/type/online/file.php   Rev. 1.15    (+5 -2 lines)
MODIFY mod/assignment/type/upload/assignment.class.php   Rev. 1.81    (+22 -2 lines)
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.76    (+64 -9 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 20/Nov/09 03:21 PM
assignment MDL-15904 Tidied up unused globals and removed reliance on $PAGE->course->maxbytes
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.77    (+2 -4 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators