[#MDL-15906] Stored file support in formslib - file upload rewrite

Issue Details (XML | Word | Printable)

Key:	MDL-15906
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14589

Stored file support in formslib - file upload rewrite

Created: 01/Aug/08 06:12 AM Updated: 03/Jun/09 04:15 PM

Return to search

Component/s:

Forms Library

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Caio SBA and Petr Skoda
Security Level:	None
Resolved date:	03/Jun/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 48 files to 'Moodle CVS' - 01/Aug/08 06:15 AM

MDL-14589 initial file storage implementation, temporary file manager, migration of course files; blog conversion ~~MDL-15905~~; assignment conversion ~~MDL-15904~~; fromslib related file improvements ~~MDL-15906~~

MODIFY	file.php	Rev. 1.54	(+35 -118 lines)
MODIFY	lib/db/install.xml	Rev. 1.159	(+41 -1 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.121	(+6 -1 lines)
MODIFY	group/lib.php	Rev. 1.18	(+6 -6 lines)
MODIFY	user/editlib.php	Rev. 1.25	(+6 -4 lines)
MODIFY	blog/lib.php	Rev. 1.100	(+39 -55 lines)
MODIFY	group/group.php	Rev. 1.22	(+2 -2 lines)
MODIFY	files/index.php	Rev. 1.134	(+212 -829 lines)
ADD	lib/file/Attic/file_packer.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/editor/tinymce/Attic/coursefiles.php	Rev. 1.5	(+3 -1 lines)
ADD	lib/file/file_storage.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/formslib.php	Rev. 1.149	(+229 -85 lines)
MODIFY	admin/roles/manage.php	Rev. 1.62	(+2 -2 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1082	(+43 -28 lines)
MODIFY	lib/filelib.php	Rev. 1.76	(+189 -16 lines)
MODIFY	mod/assignment/upload.php	Rev. 1.30	(+2 -2 lines)
ADD	lib/file/file_info_coursecat.php	Rev. 1.1	(+0 -0 lines)
ADD	lib/file/file_info_coursefile.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/db/access.php	Rev. 1.87	(+28 -0 lines)
MODIFY	config-dist.php	Rev. 1.108	(+1 -8 lines)
MODIFY	mod/assignment/db/upgrade.php	Rev. 1.18	(+119 -1 lines)
MODIFY	mod/assignment/version.php	Rev. 1.59	(+2 -2 lines)
MODIFY	lib/db/upgradelib.php	Rev. 1.18	(+167 -2 lines)
ADD	userfile.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.219	(+87 -8 lines)
MODIFY	blog/edit_form.php	Rev. 1.16	(+1 -4 lines)
MODIFY	blog/edit.php	Rev. 1.68	(+15 -9 lines)
ADD	lib/file/file_info.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/gdlib.php	Rev. 1.18	(+8 -9 lines)
ADD	lib/file/file_info_system.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/editor/htmlarea/Attic/coursefiles.php	Rev. 1.21	(+3 -1 lines)
MODIFY	mod/assignment/type/uploadsingle/assignment.class.php	Rev. 1.41	(+65 -72 lines)
ADD	lib/file/file_exceptions.php	Rev. 1.1	(+0 -0 lines)
MODIFY	version.php	Rev. 1.744	(+1 -1 lines)
ADD	draftfile.php	Rev. 1.1	(+0 -0 lines)
ADD	lib/file/stored_file.php	Rev. 1.1	(+0 -0 lines)
ADD	lib/file/file_info_user.php	Rev. 1.1	(+0 -0 lines)
ADD	lib/file/file_info_course.php	Rev. 1.1	(+0 -0 lines)
MODIFY	mod/assignment/type/upload/assignment.class.php	Rev. 1.53	(+187 -191 lines)
MODIFY	user/editadvanced_form.php	Rev. 1.20	(+1 -2 lines)
ADD	lib/file/file_browser.php	Rev. 1.1	(+0 -0 lines)
ADD	lib/file/file_info_stored.php	Rev. 1.1	(+0 -0 lines)
ADD	pluginfile.php	Rev. 1.1	(+0 -0 lines)
MODIFY	group/group_form.php	Rev. 1.8	(+1 -2 lines)
MODIFY	lib/weblib.php	Rev. 1.1119	(+3 -3 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.341	(+84 -65 lines)
MODIFY	admin/uploadpicture.php	Rev. 1.10	(+5 -5 lines)
MODIFY	user/edit_form.php	Rev. 1.28	(+1 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Aug/08 06:17 AM

nearly done.

todo:

antivirus integration
better error messages

Petr Skoda made changes - 01/Aug/08 06:17 AM

Field	Original Value	New Value
Summary	Stored file support in fomrslib - file upload rewrite	Stored file support in formslib - file upload rewrite

Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 02/Aug/08 03:08 PM

~~MDL-15906~~ Translated new strings for error messages.

MODIFY

ja_utf8/error.php

Rev. 1.82

(+6 -1 lines)

[ Permalink | « Hide ]

Caio SBA added a comment - 28/Aug/08 05:06 AM

It's a good idea to warn user when trying to upload a file that already exists instead of just override it.
It was reported in MDL-805
I post a solution there, hope to be useful

Petr Skoda committed 2 files to 'Moodle CVS' - 07/Sep/08 09:30 PM

~~MDL-15906~~ filepicker support in all file functions in formslib

MODIFY	lib/form/filepicker.php		Rev. 1.17		(+17 -13 lines)
MODIFY	lib/formslib.php		Rev. 1.156		(+111 -45 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 08/Sep/08 06:35 AM

~~MDL-15906~~ filepicker support in all file functions in formslib

MODIFY

mod/forum/post_form.php

Rev. 1.32

(+2 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 12/Sep/08 07:11 AM

~~MDL-15906~~ file picker improvements - it now keeps current file after failed server side validation or submission (input element used instead of button element)

MODIFY

lib/form/filepicker.php

Rev. 1.20

(+46 -38 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 21/May/09 05:17 AM

~~MDL-15906~~ removing obsoleted code, now in filelib.php

MODIFY

lib/file/file_storage.php

Rev. 1.28

(+0 -69 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 03/Jun/09 04:15 PM

filing separate issue for clam integration,
the old file uploading will be replaced by repository pickers, the file overwriting trouble should be solved there - thanks

Petr Skoda made changes - 03/Jun/09 04:15 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.