Moodle

trying to instantiate non existent class "message" in restorelib.php

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.2
  • Fix Version/s: None
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

In backup/restorelib.php at round about line 7330 the code is...

//We compare Moodle's versions
if ($CFG->version < $info->backup_moodle_version && $status) { $message = new message(); $message->serverversion = $CFG->version; $message->serverrelease = $CFG->release; $message->backupversion = $info->backup_moodle_version; $message->backuprelease = $info->backup_moodle_release; print_simple_box(get_string('noticenewerbackup','',$message), "center", "70%", '', "20", "noticebox"); }

the class "message" doesn't exist. I suspect that an empty object is all that was intended, but this causes a fatal error.

Activity

Hide
Gleidson Lacerda added a comment -

Confirmed:

1. Create a backup at Moodle 1.9.2+,
2. Restore a backup at Moodle 1.9.2

This crash the backup restore!!!

Show
Gleidson Lacerda added a comment - Confirmed: 1. Create a backup at Moodle 1.9.2+, 2. Restore a backup at Moodle 1.9.2 This crash the backup restore!!!
Hide
Yolanda Ordoñez Rufat added a comment -

This is already fixed in moodle 1.9.3
Take a look at tracker MDL-15282 and MDL-16311 for more information.

Hope this will help.

Show
Yolanda Ordoñez Rufat added a comment - This is already fixed in moodle 1.9.3 Take a look at tracker MDL-15282 and MDL-16311 for more information. Hope this will help.
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Dates

  • Created:
    Updated:
    Resolved: