Issue Details (XML | Word | Printable)

Key: MDL-15967
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Dan Marsden
Reporter: Urs Hunkler
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

rd.js not loaded. The PHP short form "<?=$CFG->wwwroot?>" doesn't work on all servers.

Created: 07/Aug/08 09:02 PM   Updated: 12/Aug/08 03:32 PM
Return to search
Component/s: SCORM
Affects Version/s: 1.8.6
Fix Version/s: 1.8.7, 1.9.3, 2.0

Participants: Dan Marsden, Tim Hunt and Urs Hunkler
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 08/Aug/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
mod/scorm/player.php Line 140
<script type="text/javascript" src="<?=$CFG->wwwroot?>/mod/scorm/rd.js"></script>

The PHP short form "<?=$CFG->wwwroot?>" doesn't work on all servers. Under certain circumstances the short form is not resolved and the script not loaded. I have gotten this issue now.

Moodle programing guidelines propose not to use the short forms. Please replace with
<script type="text/javascript" src="<?php echo $CFG->wwwroot ?>/mod/scorm/rd.js"></script>


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Marsden committed 1 file to 'Moodle CVS' - 08/Aug/08 04:46 AM
MDL-15967 - must use full php tags, not shortags - thanks Urs
MODIFY mod/scorm/player.php   Rev. 1.45    (+3 -3 lines)
Dan Marsden committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/Aug/08 04:47 AM
MDL-15967 - must use full php tags, not shortags - thanks Urs merged from head
MODIFY mod/scorm/player.php   Rev. 1.34.2.6    (+3 -3 lines)
Dan Marsden committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 08/Aug/08 04:48 AM
MDL-15967 - must use full php tags, not shortags - thanks Urs merged from head
MODIFY mod/scorm/player.php   Rev. 1.22.2.11    (+3 -3 lines)