Issue Details (XML | Word | Printable)

Key: MDL-15986
Type: Improvement Improvement
Status: Open Open
Priority: Major Major
Assignee: Eloy Lafuente (stronk7)
Reporter: Chris Bandy
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Analyze all integers in DB

Created: 09/Aug/08 07:29 AM   Updated: 09/Aug/08 07:30 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 1.9.2
Fix Version/s: None

File Attachments: 1. Text File all_integers.patch (4 kB)

Environment: PostgreSQL 8.1.11
Issue Links:
Relates
 

Database: Any
Participants: Chris Bandy and Eloy Lafuente (stronk7)
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Why stop at fixing big integers? Attached is the beginnings of a patch (against the below 1.9.2) to correct all integer sizes for all database types.

I only have PostgreSQL to test with, so I only filled in the integer lengths for MySQL implied in the original code. Also, I found the applicable PostgreSQL lengths by comparing a fresh install of 1.9.2+ (Build: 20080725) to an upgrade from 1.8.5+ (Build: 20080507). Notice XMLDB integers with length="9" are neither tested nor written for PostgreSQL here.

Someone can expand this patch with MySQL information, and change the XMLDB action from "Check Bigints" to "Check Integer Lengths."

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
There are no comments yet on this issue.