Issue Details (XML | Word | Printable)

Key: MDL-16003
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Petr Skoda
Reporter: Tatsuya Shirai
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

2nd parameter is unnecessary for function admin_externalpage_setup() in admin/uploadpicture.php

Created: 12/Aug/08 04:34 PM   Updated: 19/Aug/08 10:56 AM
Return to search
Component/s: Other
Affects Version/s: 1.9
Fix Version/s: 1.9.3

Participants: Petr Skoda and Tatsuya Shirai
Security Level: None
QA Assignee: Mathieu Petit-Clair
Resolved date: 18/Aug/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Line 35

$adminroot = admin_get_root();
admin_externalpage_setup('uploadpictures', $adminroot);

This statements are old style (for Moodle1.8).

Only uploadpicture.php has 2nd parameter, other ones had been corrected before.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 18/Aug/08 06:52 AM
MDL-16003 changing to new adminroot style - thanks Tatsuya Shirai
MODIFY admin/uploadpicture.php   Rev. 1.1.2.5    (+2 -4 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/Aug/08 06:53 AM
MDL-16003 changing to new adminroot style - thanks Tatsuya Shirai
MODIFY admin/uploadpicture.php   Rev. 1.12    (+2 -4 lines)