Moodle

default to label for weblib's popup_form

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: None
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

there isn't a way to have the popup_form in /lib/weblib.php default to the label, which is useful to keep the new blog menu I laid out making sense. Thus, I made a change so that if there is no selection provided, the default will be to select the label.

Attachments

  1. Text File
    patch-16036-080814-labeldefault.patch
    14/Aug/08 11:38 AM
    0.9 kB
    Mathieu Petit-Clair
  2. Text File
    weblib-patch-08-13-2008.txt
    14/Aug/08 7:47 AM
    0.7 kB
    Joseph Morwick
  3. Text File
    weblib-patch-08-13-2008-2.txt
    14/Aug/08 7:52 AM
    0.8 kB
    Joseph Morwick

Issue Links

This issue blocks:
MDL-15435 Blog Improvements / Blog Assignment (GSoC) Minor Development in progress

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joseph Morwick added a comment -

This patch makes popup_form select the label by default when nothing is specified for the selected index

Show
Joseph Morwick added a comment - This patch makes popup_form select the label by default when nothing is specified for the selected index
Hide
Permalink
Joseph Morwick added a comment -

In the case that one of the options supplied to the popup_form is the zero value, both that option and the label would be 'selected' if no select parameter was provided. In order to be clean, I check for such an option first and if one is present, the label is not given the select attribute (the option should take precedence).

Show
Joseph Morwick added a comment - In the case that one of the options supplied to the popup_form is the zero value, both that option and the label would be 'selected' if no select parameter was provided. In order to be clean, I check for such an option first and if one is present, the label is not given the select attribute (the option should take precedence).
Hide
Permalink
Mathieu Petit-Clair added a comment -

The latest file (patch-16036-080814-labeldefault.txt) contains some minor code formatting changes.

Looks good to me...

Show
Mathieu Petit-Clair added a comment - The latest file (patch-16036-080814-labeldefault.txt) contains some minor code formatting changes. Looks good to me...
Hide
Permalink
Mathieu Petit-Clair added a comment -

Committed the CVS. Thanks!

Show
Mathieu Petit-Clair added a comment - Committed the CVS. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.