Moodle

Missing aggregationcoef.html help file

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.3
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Moodle install is missing 'aggregationcoef.html' help file. To reproduce, have a subcategory in the gradebook that is a 'Weighted Mean of Grades'. Then click:
--'Grades'
--'Edit Categories and Items'
--Click on the 'Edit' icon by the category
--Click on the help icon next to 'Item Weight'

A dialog pops us that says "Help file "aggregationcoef.html" could not be found!"

I've checked for this file in 1.9.2+, 1.9.2, and can't seem to find it anywhere. Either the php is looking for the wrong file, or the file doesn't exist, IMHO.

--Marty

Issue Links

This issue is duplicated by:
MDL-16354 Item weight/Aggregation coefficient help file not found Minor Closed
This issue has been marked as being related by:
MDL-16416 Consistency issue with the terms aggregation coefficient and item weight Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marty Gilbert added a comment -

Screenshot of error screen

Show
Marty Gilbert added a comment - Screenshot of error screen
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Adressing for 1.9.3, assigning to Helen. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Adressing for 1.9.3, assigning to Helen. Thanks!
Hide
Permalink
Helen Foster added a comment -

Marty, thanks for reporting this issue The item weight help file was actually aggregationcoefweight.html. It's fixed in 1.9.3 and 2.0.

Show
Helen Foster added a comment - Marty, thanks for reporting this issue The item weight help file was actually aggregationcoefweight.html. It's fixed in 1.9.3 and 2.0.
Hide
Permalink
Daniel Miksik added a comment -

Thanks for the fix! I just wonder whether the content of the aggregationcoefweight.html is appropriate. If I get it right, it is used both for "Item weight" and "Aggregation coefficient" settings (depending on what aggregation method is selected in the nesting category). At present, there is no mention of "Aggregation coefficient" in the help file (and in the Docs, neither). Perhaps the text of the help file could be expanded to cover and explain in more detail what both these settings mean?

Show
Daniel Miksik added a comment - Thanks for the fix! I just wonder whether the content of the aggregationcoefweight.html is appropriate. If I get it right, it is used both for "Item weight" and "Aggregation coefficient" settings (depending on what aggregation method is selected in the nesting category). At present, there is no mention of "Aggregation coefficient" in the help file (and in the Docs, neither). Perhaps the text of the help file could be expanded to cover and explain in more detail what both these settings mean?
Hide
Permalink
Tim Hunt added a comment -

Helen, I tested and the help file is there, but I don't think I can close this until you have responded to Daniel's last comment.

Show
Tim Hunt added a comment - Helen, I tested and the help file is there, but I don't think I can close this until you have responded to Daniel's last comment.
Hide
Permalink
Helen Foster added a comment -

Daniel, thanks for your comment.

As you point out, there is an aggregation coefficient setting for subcategories in a category with "Sum of grades" aggregation, whereas there is an item weight setting for subcategories in a category with "Weighted mean of grades" aggregation. Both settings have the same help file.

It seems that "aggregation coefficient" and "item weight" mean the same thing, and so we should be consistent and use either one term or the other - see MDL-16416.

Show
Helen Foster added a comment - Daniel, thanks for your comment. As you point out, there is an aggregation coefficient setting for subcategories in a category with "Sum of grades" aggregation, whereas there is an item weight setting for subcategories in a category with "Weighted mean of grades" aggregation. Both settings have the same help file. It seems that "aggregation coefficient" and "item weight" mean the same thing, and so we should be consistent and use either one term or the other - see MDL-16416.
Hide
Permalink
Daniel Miksik added a comment -

If there is a single term used, then there is really no problem; my only point was to have the help file correspond to the name of the setting.

Show
Daniel Miksik added a comment - If there is a single term used, then there is really no problem; my only point was to have the help file correspond to the name of the setting.
Hide
Permalink
Tim Hunt added a comment -

Thanks for the clarification. Closing.

Show
Tim Hunt added a comment - Thanks for the clarification. Closing.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.