Issue Details (XML | Word | Printable)

Key: MDL-16050
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Helen Foster
Reporter: Marty Gilbert
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Missing aggregationcoef.html help file

Created: 15/Aug/08 12:00 AM   Updated: 10/Sep/08 09:53 AM
Component/s: Gradebook
Affects Version/s: 1.9.2
Fix Version/s: 1.9.3

File Attachments: None
Image Attachments:

1. MissingHelpFile.png
(24 kB)
Issue Links:
Duplicate
 
Relates
 

Participants: Daniel Miksik, Eloy Lafuente (stronk7), Helen Foster, Marty Gilbert and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 05/Sep/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Moodle install is missing 'aggregationcoef.html' help file. To reproduce, have a subcategory in the gradebook that is a 'Weighted Mean of Grades'. Then click:
--'Grades'
--'Edit Categories and Items'
--Click on the 'Edit' icon by the category
--Click on the help icon next to 'Item Weight'

A dialog pops us that says "Help file "aggregationcoef.html" could not be found!"

I've checked for this file in 1.9.2+, 1.9.2, and can't seem to find it anywhere. Either the php is looking for the wrong file, or the file doesn't exist, IMHO.

--Marty



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Marty Gilbert added a comment - 15/Aug/08 12:02 AM
Screenshot of error screen

Eloy Lafuente (stronk7) added a comment - 01/Sep/08 03:58 PM
Adressing for 1.9.3, assigning to Helen. Thanks!

Helen Foster added a comment - 05/Sep/08 09:56 PM
Marty, thanks for reporting this issue The item weight help file was actually aggregationcoefweight.html. It's fixed in 1.9.3 and 2.0.

Daniel Miksik added a comment - 06/Sep/08 05:54 AM
Thanks for the fix! I just wonder whether the content of the aggregationcoefweight.html is appropriate. If I get it right, it is used both for "Item weight" and "Aggregation coefficient" settings (depending on what aggregation method is selected in the nesting category). At present, there is no mention of "Aggregation coefficient" in the help file (and in the Docs, neither). Perhaps the text of the help file could be expanded to cover and explain in more detail what both these settings mean?

Tim Hunt added a comment - 09/Sep/08 10:54 AM
Helen, I tested and the help file is there, but I don't think I can close this until you have responded to Daniel's last comment.

Helen Foster added a comment - 09/Sep/08 06:21 PM
Daniel, thanks for your comment.

As you point out, there is an aggregation coefficient setting for subcategories in a category with "Sum of grades" aggregation, whereas there is an item weight setting for subcategories in a category with "Weighted mean of grades" aggregation. Both settings have the same help file.

It seems that "aggregation coefficient" and "item weight" mean the same thing, and so we should be consistent and use either one term or the other - see MDL-16416.


Daniel Miksik added a comment - 09/Sep/08 09:18 PM
If there is a single term used, then there is really no problem; my only point was to have the help file correspond to the name of the setting.

Tim Hunt added a comment - 10/Sep/08 09:53 AM
Thanks for the clarification. Closing.