Moodle

XMLDB editor does not generate upgrade_mod_savepoint calls

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Of course, depending on which file you are editing, it will need to be upgrade_mod_savepoint, upgrade_main_savepoint calls, upgrade_plugin_savepoint, ... but it would still be good to get this right.

Issue Links

This issue has been marked as being related by:
MDL-19346 Discrepancies between plugins declared in get_plugin_types() and detected by get_db_directories() Major Closed
MDL-19350 Review all upgrade.php scripts in 2.0 to confirm all them have correct savepoints in use Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Also, it generates deprecated dmllib calls!

Show
Tim Hunt added a comment - Also, it generates deprecated dmllib calls!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Done.

1) moved upgrade_savepoint_php() to XMLDBAction class.
2) added support for all standard plugins with lib/mod/block exceptions
3) not found any deprecated xmldb call, Tim, surely they have been fixed in the interim.

Resolving as fixed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Done. 1) moved upgrade_savepoint_php() to XMLDBAction class. 2) added support for all standard plugins with lib/mod/block exceptions 3) not found any deprecated xmldb call, Tim, surely they have been fixed in the interim. Resolving as fixed. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.