[#MDL-16070] Do not use $a[0] syntax in lang packs

Issue Details (XML | Word | Printable)

Key:	MDL-16070
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Critical
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Do not use $a[0] syntax in lang packs

Created: 16/Aug/08 06:18 PM Updated: 16/Aug/08 08:17 PM

Return to search

Component/s:

Languages

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Petr Skoda
Security Level:	None
Resolved date:	16/Aug/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

This was wrongly introduced in 1.9 in mnet and auth code, we should definitely not add new tricks into lang packs, this is only going to confuse translators!
Fixing all new strings introduced in 2.0 with

$a = (object)array('something'=>$something, 'other'=>$other)

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 85 files to 'Moodle CVS' - 16/Aug/08 08:16 PM

~~MDL-16002~~ rewritten upgrade locking and better upgrade progress tracking; ~~MDL-16070~~ Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes

MODIFY	mod/assignment/db/upgrade.php	Rev. 1.19	(+10 -10 lines)
MODIFY	blocks/recent_activity/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.222	(+43 -27 lines)
MODIFY	blocks/rss_client/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	enrol/paypal/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	lib/weblib.php	Rev. 1.1125	(+3 -3 lines)
MODIFY	mod/label/db/upgrade.php	Rev. 1.8	(+8 -12 lines)
MODIFY	message/output/email/db/upgrade.php	Rev. 1.2	(+4 -4 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.228	(+34 -29 lines)
MODIFY	blocks/search_forums/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	question/type/calculated/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	mod/quiz/Attic/pagelib.php	Rev. 1.18	(+2 -2 lines)
MODIFY	blocks/participants/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	question/type/randomsamatch/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	admin/index.php	Rev. 1.335	(+156 -174 lines)
MODIFY	mod/forum/rate.php	Rev. 1.29	(+3 -5 lines)
MODIFY	mod/hotpot/lib.php	Rev. 1.105	(+51 -40 lines)
MODIFY	lib/db/upgradelib.php	Rev. 1.19	(+9 -7 lines)
MODIFY	admin/lang.php	Rev. 1.122	(+4 -4 lines)
MODIFY	admin/settings/Attic/misc.php	Rev. 1.22	(+3 -3 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1095	(+42 -3 lines)
MODIFY	blocks/news_items/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	lib/setup.php	Rev. 1.245	(+10 -1 lines)
MODIFY	question/type/essay/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	lang/en_utf8/forum.php	Rev. 1.43	(+1 -3 lines)
MODIFY	lib/blocklib.php	Rev. 1.146	(+3 -7 lines)
MODIFY	mod/data/lib.php	Rev. 1.194	(+46 -29 lines)
MODIFY	lib/adminlib.php	Rev. 1.240	(+134 -83 lines)
MODIFY	question/type/datasetdependent/db/Attic/upgrade.php	Rev. 1.2	(+7 -4 lines)
MODIFY	mod/survey/db/upgrade.php	Rev. 1.5	(+7 -13 lines)
MODIFY	blocks/social_activities/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	blocks/db/Attic/upgrade.php	Rev. 1.7	(+6 -5 lines)
MODIFY	message/output/popup/db/upgrade.php	Rev. 1.2	(+4 -4 lines)
MODIFY	blocks/admin/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	lib/accesslib.php	Rev. 1.510	(+2 -2 lines)
MODIFY	question/type/truefalse/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	lang/en_utf8/admin.php	Rev. 1.219	(+1 -0 lines)
MODIFY	message/output/jabber/db/upgrade.php	Rev. 1.2	(+4 -4 lines)
MODIFY	user/editlib.php	Rev. 1.26	(+3 -3 lines)
MODIFY	mod/quiz/db/upgrade.php	Rev. 1.23	(+6 -5 lines)
MODIFY	lang/en_utf8/debug.php	Rev. 1.16	(+8 -9 lines)
MODIFY	blocks/calendar_month/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	mod/data/rate.php	Rev. 1.15	(+3 -3 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.347	(+46 -27 lines)
MODIFY	lang/en_utf8/data.php	Rev. 1.77	(+1 -3 lines)
MODIFY	blocks/search/config_global.html	Rev. 1.9	(+2 -3 lines)
MODIFY	blocks/calendar_upcoming/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	blocks/activity_modules/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	blocks/course_list/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.124	(+10 -9 lines)
MODIFY	mod/glossary/db/upgrade.php	Rev. 1.12	(+7 -13 lines)
MODIFY	enrol/authorize/db/upgrade.php	Rev. 2.6	(+7 -4 lines)
MODIFY	mod/scorm/lib.php	Rev. 1.100	(+41 -26 lines)
MODIFY	mod/forum/lib.php	Rev. 1.703	(+46 -29 lines)
MODIFY	mod/data/db/upgrade.php	Rev. 1.22	(+6 -5 lines)
MODIFY	mod/glossary/rate.php	Rev. 1.17	(+3 -3 lines)
MODIFY	question/type/multianswer/db/upgrade.php	Rev. 1.8	(+7 -13 lines)
MODIFY	mod/quiz/report/statistics/db/upgrade.php	Rev. 1.5	(+2 -2 lines)
MODIFY	question/type/numerical/db/upgrade.php	Rev. 1.9	(+7 -4 lines)
MODIFY	mod/lesson/db/upgrade.php	Rev. 1.20	(+6 -5 lines)
MODIFY	mod/quiz/report/overview/db/upgrade.php	Rev. 1.2	(+3 -5 lines)
MODIFY	mod/forum/db/upgrade.php	Rev. 1.22	(+7 -20 lines)
MODIFY	course/format/README.txt	Rev. 1.3	(+1 -1 lines)
MODIFY	mod/scorm/db/upgrade.php	Rev. 1.19	(+7 -6 lines)
MODIFY	question/type/shortanswer/db/upgrade.php	Rev. 1.5	(+7 -4 lines)
MODIFY	blocks/course_summary/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	mod/wiki/db/upgrade.php	Rev. 1.5	(+7 -13 lines)
MODIFY	mod/hotpot/db/upgrade.php	Rev. 1.5	(+9 -15 lines)
MODIFY	mod/chat/db/upgrade.php	Rev. 1.8	(+10 -9 lines)
MODIFY	search/query.php	Rev. 1.29	(+0 -3 lines)
MODIFY	mod/feedback/db/upgrade.php	Rev. 1.20	(+6 -5 lines)
MODIFY	question/type/multichoice/db/upgrade.php	Rev. 1.9	(+7 -4 lines)
MODIFY	lib/pagelib.php	Rev. 1.75	(+6 -6 lines)
MODIFY	backup/db/Attic/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	mod/quiz/lib.php	Rev. 1.313	(+45 -31 lines)
MODIFY	admin/auth_config.php	Rev. 1.23	(+1 -1 lines)
MODIFY	blocks/online_users/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	mod/resource/db/upgrade.php	Rev. 1.10	(+7 -12 lines)
MODIFY	version.php	Rev. 1.768	(+1 -1 lines)
MODIFY	mod/choice/db/upgrade.php	Rev. 1.5	(+7 -13 lines)
MODIFY	mod/lesson/lib.php	Rev. 1.55	(+46 -32 lines)
MODIFY	blocks/section_links/db/upgrade.php	Rev. 1.4	(+7 -4 lines)
MODIFY	blocks/search/db/upgrade.php	Rev. 1.11	(+7 -4 lines)
MODIFY	admin/Attic/cliupgrade.php	Rev. 1.25	(+0 -9 lines)
MODIFY	question/type/match/db/upgrade.php	Rev. 1.5	(+7 -4 lines)

Petr Skoda committed 17 files to 'Lang CVS' - 16/Aug/08 08:17 PM

~~MDL-16070~~ Do not use $a[0] syntax in lang packs + various other improvements and fixes

MODIFY	de_utf8/debug.php	Rev. 1.8	(+6 -8 lines)
MODIFY	ko_utf8/error.php	Rev. 1.50	(+7 -8 lines)
MODIFY	ja_utf8/debug.php	Rev. 1.14	(+6 -8 lines)
MODIFY	hu_utf8/error.php	Rev. 1.11	(+7 -7 lines)
MODIFY	si_utf8/debug.php	Rev. 1.8	(+5 -7 lines)
MODIFY	ko_utf8/debug.php	Rev. 1.12	(+6 -8 lines)
MODIFY	fr_utf8/error.php	Rev. 1.128	(+8 -9 lines)
MODIFY	fr_utf8/debug.php	Rev. 1.15	(+6 -8 lines)
MODIFY	eu_utf8/error.php	Rev. 1.11	(+1 -1 lines)
MODIFY	ja_utf8/error.php	Rev. 1.86	(+7 -8 lines)
MODIFY	sr_cr_utf8/debug.php	Rev. 1.2	(+6 -8 lines)
MODIFY	tr_utf8/debug.php	Rev. 1.3	(+6 -8 lines)
MODIFY	de_utf8/error.php	Rev. 1.34	(+5 -6 lines)
MODIFY	sr_lt_utf8/debug.php	Rev. 1.2	(+6 -8 lines)
MODIFY	nl_utf8/debug.php	Rev. 1.6	(+6 -8 lines)
MODIFY	si_utf8/error.php	Rev. 1.13	(+3 -3 lines)
MODIFY	nl_utf8/error.php	Rev. 1.31	(+7 -8 lines)

Mitsuhiro Yoshida committed 6 files to 'Lang CVS' - 17/Aug/08 04:50 PM

~~MDL-16002~~ Translated new strings for upgrade.
~~MDL-16070~~ Updated translated strings for upgrade based on lang/en_utf8 fix.

MODIFY	ja_utf8/debug.php	Rev. 1.15	(+8 -4 lines)
MODIFY	ja_utf8/data.php	Rev. 1.99	(+8 -8 lines)
MODIFY	ja_utf8/forum.php	Rev. 1.74	(+3 -3 lines)
MODIFY	ja_utf8/README	Rev. 1.788	(+1 -1 lines)
MODIFY	ja_utf8/error.php	Rev. 1.87	(+9 -6 lines)
MODIFY	ja_utf8/admin.php	Rev. 1.289	(+12 -11 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.