Issue Details (XML | Word | Printable)

Key: MDL-16089
Type: Sub-task Sub-task
Status: Open Open
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 1
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14589

File storage conversion Resource

Created: 18/Aug/08 05:28 AM   Updated: 14/Aug/09 03:04 AM
Component/s: Resource
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File Folder edit files.bmml (4 kB)
2. Text File Folder edit files.bmml (4 kB)
3. Text File Folder edit files.bmml (4 kB)
4. Text File Folder edit files.bmml (3 kB)
5. Text File Folder edit files.bmml (2 kB)
6. Text File Folder modedit.bmml (6 kB)
7. Text File Folder modedit.bmml (6 kB)
8. Text File Folder modedit.bmml (7 kB)
9. Text File Folder modedit.bmml (6 kB)
10. Text File Folder modedit.bmml (6 kB)
11. Text File Folder modedit.bmml (6 kB)
12. Text File Folder modedit.bmml (5 kB)
13. Text File Folder view.bmml (5 kB)
14. Text File Folder view.bmml (6 kB)
15. Text File Folder view.bmml (3 kB)
16. Text File Folder view.bmml (3 kB)
17. Text File Folder view.bmml (2 kB)
18. Text File Folder view.bmml (2 kB)
19. Text File Folder view.bmml (6 kB)
20. Text File IMS modedit.bmml (12 kB)
21. Text File IMS modedit.bmml (12 kB)
22. Text File IMS modedit.bmml (11 kB)
23. Text File IMS modedit.bmml (11 kB)
24. Text File IMS modedit.bmml (11 kB)
25. Text File IMS modedit.bmml (11 kB)
26. Text File Page modedit.bmml (10 kB)
27. Text File Page modedit.bmml (9 kB)
28. Text File Page modedit.bmml (9 kB)
29. Text File Page modedit.bmml (9 kB)
30. Text File Page modedit.bmml (8 kB)
31. Text File Page modedit.bmml (8 kB)
32. Text File Page modedit.bmml (8 kB)
33. Text File Page modedit.bmml (6 kB)
34. Text File Resource modedit.bmml (13 kB)
35. Text File Resource modedit.bmml (13 kB)
36. Text File Resource modedit.bmml (13 kB)
37. Text File Resource modedit.bmml (13 kB)
38. Text File Resource modedit.bmml (13 kB)
39. Text File Resource modedit.bmml (11 kB)
40. Text File Resource modedit.bmml (11 kB)
41. Text File Resource modedit.bmml (11 kB)
42. Text File Resource modedit.bmml (12 kB)
43. Text File Resource modedit.bmml (11 kB)
44. Text File Resource modedit.bmml (11 kB)
45. Text File Resource modedit.bmml (10 kB)
46. Text File Resource modedit.bmml (10 kB)
47. Text File URL modedit.bmml (11 kB)
48. Text File URL modedit.bmml (12 kB)
49. Text File URL modedit.bmml (12 kB)
50. Text File URL modedit.bmml (11 kB)
51. Text File URL modedit.bmml (10 kB)
52. Text File URL modedit.bmml (10 kB)
53. Text File URL modedit.bmml (10 kB)
54. Text File URL modedit.bmml (10 kB)
55. Text File URL modedit.bmml (10 kB)
56. Text File URL modedit.bmml (10 kB)
57. Text File URL modedit.bmml (11 kB)

Image Attachments:

1. Folder edit files.png
(36 kB)

2. Folder modedit.png
(54 kB)

3. Folder view.png
(61 kB)

4. IMS modedit.png
(111 kB)

5. Page modedit.png
(130 kB)

6. Resource modedit.png
(133 kB)

7. URL modedit.png
(121 kB)
Issue Links:
Dependency
 
Relates
 

Participants: Martin Dougiamas, Nadav Kavalerchik and Petr Skoda
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nadav Kavalerchik added a comment - 12/May/09 03:11 AM
i am missing "file choose" button/icon on the popup window of the (new) file manager.
when added "link to file or website" resource.

is this the place to report it ? (is it not implemented yet ?)


Petr Skoda added a comment - 12/May/09 04:20 AM
There is no need to report anything , the work was not even started

Petr Skoda added a comment - 05/Jun/09 04:41 AM
Added UI Mockup: <Folder modedit>

Petr Skoda added a comment - 05/Jun/09 04:45 AM
Added UI Mockup: <Folder view>

Petr Skoda added a comment - 05/Jun/09 05:09 AM
Added UI Mockup: <Folder edit files>

Petr Skoda added a comment - 05/Jun/09 05:58 AM
Added UI Mockup: <Page modedit>

Petr Skoda added a comment - 05/Jun/09 04:03 PM
Added UI Mockup: <File modedit>

Petr Skoda added a comment - 05/Jun/09 04:37 PM
Added UI Mockup: <Resource modedit>

Petr Skoda added a comment - 05/Jun/09 05:45 PM
Added UI Mockup: <URL modedit>

Petr Skoda added a comment - 06/Jun/09 04:45 AM
Added UI Mockup: <IMS modedit>

Martin Dougiamas added a comment - 27/Jul/09 11:53 PM - edited
I've just been playing with the latest version, Petr. Looks pretty smart!

Here are some minor GUI/English things that I thought as I went through.

  • "File folder" should just be "Folder" in English I think.
  • In "Page" plugin:
  • Display ... What does Open mean? Should it possibly just be "normal" ?
  • "Print heading" should be "Display page name"
  • "Print description" should be "Display page description".
  • "Resource file" is so much like "Folder" ... it's a bit annoying. sigh.
  • We could possibly make it clearer that we are adding "supporting files" like images etc.
  • We do really have to come up with a nice way to manage the files (I know you know)
  • Why do we have a filters option here and not on Page?
  • Does popup height/width also control embedding size? It should (and thus needs rename). Also need "max" in the menu as an option for 100%.
  • Same wording issues as Page.
  • "URL"
  • I don't think we need to make a URL picker in Moodle 2.0
  • Same wording issues as Page.
  • I tried to embed a web page and it told me to click a link instead.
  • Frame worked, but we need some admin setting to disable frames (admin policy).

That's all for now!


Petr Skoda added a comment - 28/Jul/09 12:23 AM - edited
Folder:
  • File folder - renamed to Folder

Page:

  • by default only "normal" options is available which removes it completely from modedit - I agree we need better name, normal here means it open like all other modules
  • print xxx renamed in all mods

Folder x Resource file:

  • Folder may have different features like image slideshow and preview, it may list file details
  • Resource has special display options

Resource file:

  • filtering option is for uploaded files, not texts - we only had one global annoying switch until now
  • the popup width/height only control popups - it is removed if popup not allowed, and is disabled for all other display options
  • if somebody wants to embed something I would expect they would use Page instead, the resource always tries to display it as big as possible

URL:

  • you can not embed external URLs, sorry IE trouble - we would have to resort to iframes(not allowed in strict); going to add explicit warning there.
  • I found a bug in mimetype detection code that was breaking the embedding if url ended with /
  • yes, available options are fully configurable

Petr Skoda added a comment - 28/Jul/09 12:41 AM
There was a question why not all display types are not available in all resource or other modules in general:

1/ RESOURCELIB_DISPLAY_EMBED - files and URLs, embedding may be very problematic especially in IE; ideally only file types that are known to work should be used (images and partially PDF), please note that IE supports embedding only from the same domain (MDL-14609)

2/ RESOURCELIB_DISPLAY_FRAME - not accessible but works 100%

3/ RESOURCELIB_DISPLAY_NEW - recommended for links to external sites, can be used for links to general files too; the main reason is we do not want out users to loose navigation elements (the only option they have is to close the browser); most other uses are not recommended for accessibility reasons; I think this should be supported in all modules and activities or only in Resource file+URL

4/ RESOURCELIB_DISPLAY_DOWNLOAD - for locally stored files only, suitable for distribution of binary files; predates Portfolio - all others use cases should be handled by portfolio export code

5/ RESOURCELIB_DISPLAY_OPEN - normal opening

6/ RESOURCELIB_DISPLAY_POPUP - accessibility problems, I would prefer JS overlays with Ajax instead; implemented for BC reasons only

7/ RESOURCELIB_DISPLAY_AUTO - this just tries to guess what is usable and accessible for given file, URL, etc.


Petr Skoda added a comment - 28/Jul/09 03:43 AM
I have tried to rename "Resource file" to just "File" - looks better imho.