Moodle

File storage conversion Resource

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE
  1. Folder edit files.bmml
    08/Jun/09 9:07 PM
    4 kB
    Petr Škoda (skodak)
  2. Folder edit files.bmml
    06/Jun/09 5:02 AM
    4 kB
    Petr Škoda (skodak)
  3. Folder edit files.bmml
    05/Jun/09 5:42 AM
    4 kB
    Petr Škoda (skodak)
  4. Folder edit files.bmml
    05/Jun/09 5:26 AM
    3 kB
    Petr Škoda (skodak)
  5. Folder edit files.bmml
    05/Jun/09 5:09 AM
    2 kB
    Petr Škoda (skodak)
  6. Folder modedit.bmml
    21/Jun/09 6:11 PM
    6 kB
    Petr Škoda (skodak)
  7. Folder modedit.bmml
    08/Jun/09 7:33 PM
    6 kB
    Petr Škoda (skodak)
  8. Folder modedit.bmml
    06/Jun/09 4:38 AM
    7 kB
    Petr Škoda (skodak)
  9. Folder modedit.bmml
    05/Jun/09 3:46 PM
    6 kB
    Petr Škoda (skodak)
  10. Folder modedit.bmml
    05/Jun/09 6:24 AM
    6 kB
    Petr Škoda (skodak)
  11. Folder modedit.bmml
    05/Jun/09 4:44 AM
    6 kB
    Petr Škoda (skodak)
  12. Folder modedit.bmml
    05/Jun/09 4:41 AM
    5 kB
    Petr Škoda (skodak)
  13. Folder view.bmml
    21/Jun/09 6:11 PM
    5 kB
    Petr Škoda (skodak)
  14. Folder view.bmml
    08/Jun/09 8:08 PM
    6 kB
    Petr Škoda (skodak)
  15. Folder view.bmml
    05/Jun/09 3:48 PM
    3 kB
    Petr Škoda (skodak)
  16. Folder view.bmml
    05/Jun/09 6:33 AM
    3 kB
    Petr Škoda (skodak)
  17. Folder view.bmml
    05/Jun/09 4:53 AM
    2 kB
    Petr Škoda (skodak)
  18. Folder view.bmml
    05/Jun/09 4:51 AM
    2 kB
    Petr Škoda (skodak)
  19. Folder view.bmml
    05/Jun/09 4:45 AM
    6 kB
    Petr Škoda (skodak)
  20. IMS modedit.bmml
    08/Jun/09 8:16 PM
    12 kB
    Petr Škoda (skodak)
  21. IMS modedit.bmml
    08/Jun/09 12:40 AM
    12 kB
    Petr Škoda (skodak)
  22. IMS modedit.bmml
    06/Jun/09 5:00 AM
    11 kB
    Petr Škoda (skodak)
  23. IMS modedit.bmml
    06/Jun/09 4:54 AM
    11 kB
    Petr Škoda (skodak)
  24. IMS modedit.bmml
    06/Jun/09 4:53 AM
    11 kB
    Petr Škoda (skodak)
  25. IMS modedit.bmml
    06/Jun/09 4:45 AM
    11 kB
    Petr Škoda (skodak)
  26. Page modedit.bmml
    08/Jun/09 7:25 PM
    10 kB
    Petr Škoda (skodak)
  27. Page modedit.bmml
    06/Jun/09 4:24 AM
    9 kB
    Petr Škoda (skodak)
  28. Page modedit.bmml
    05/Jun/09 5:56 PM
    9 kB
    Petr Škoda (skodak)
  29. Page modedit.bmml
    05/Jun/09 3:44 PM
    9 kB
    Petr Škoda (skodak)
  30. Page modedit.bmml
    05/Jun/09 6:30 AM
    8 kB
    Petr Škoda (skodak)
  31. Page modedit.bmml
    05/Jun/09 6:22 AM
    8 kB
    Petr Škoda (skodak)
  32. Page modedit.bmml
    05/Jun/09 6:21 AM
    8 kB
    Petr Škoda (skodak)
  33. Page modedit.bmml
    05/Jun/09 5:58 AM
    6 kB
    Petr Škoda (skodak)
  34. Resource modedit.bmml
    08/Jun/09 7:28 PM
    13 kB
    Petr Škoda (skodak)
  35. Resource modedit.bmml
    08/Jun/09 7:19 PM
    13 kB
    Petr Škoda (skodak)
  36. Resource modedit.bmml
    08/Jun/09 7:15 PM
    13 kB
    Petr Škoda (skodak)
  37. Resource modedit.bmml
    08/Jun/09 7:10 PM
    13 kB
    Petr Škoda (skodak)
  38. Resource modedit.bmml
    08/Jun/09 12:32 AM
    13 kB
    Petr Škoda (skodak)
  39. Resource modedit.bmml
    06/Jun/09 4:40 AM
    11 kB
    Petr Škoda (skodak)
  40. Resource modedit.bmml
    06/Jun/09 4:36 AM
    11 kB
    Petr Škoda (skodak)
  41. Resource modedit.bmml
    06/Jun/09 4:35 AM
    11 kB
    Petr Škoda (skodak)
  42. Resource modedit.bmml
    06/Jun/09 4:27 AM
    12 kB
    Petr Škoda (skodak)
  43. Resource modedit.bmml
    05/Jun/09 5:52 PM
    11 kB
    Petr Škoda (skodak)
  44. Resource modedit.bmml
    05/Jun/09 4:46 PM
    11 kB
    Petr Škoda (skodak)
  45. Resource modedit.bmml
    05/Jun/09 4:39 PM
    10 kB
    Petr Škoda (skodak)
  46. Resource modedit.bmml
    05/Jun/09 4:37 PM
    10 kB
    Petr Škoda (skodak)
  47. URL modedit.bmml
    08/Jun/09 8:19 PM
    11 kB
    Petr Škoda (skodak)
  48. URL modedit.bmml
    08/Jun/09 12:20 AM
    12 kB
    Petr Škoda (skodak)
  49. URL modedit.bmml
    08/Jun/09 12:19 AM
    12 kB
    Petr Škoda (skodak)
  50. URL modedit.bmml
    08/Jun/09 12:17 AM
    11 kB
    Petr Škoda (skodak)
  51. URL modedit.bmml
    06/Jun/09 4:34 AM
    10 kB
    Petr Škoda (skodak)
  52. URL modedit.bmml
    06/Jun/09 4:24 AM
    10 kB
    Petr Škoda (skodak)
  53. URL modedit.bmml
    05/Jun/09 6:02 PM
    10 kB
    Petr Škoda (skodak)
  54. URL modedit.bmml
    05/Jun/09 5:59 PM
    10 kB
    Petr Škoda (skodak)
  55. URL modedit.bmml
    05/Jun/09 5:53 PM
    10 kB
    Petr Škoda (skodak)
  56. URL modedit.bmml
    05/Jun/09 5:51 PM
    10 kB
    Petr Škoda (skodak)
  57. URL modedit.bmml
    05/Jun/09 5:45 PM
    11 kB
    Petr Škoda (skodak)
  1. Folder edit files.png
    36 kB
    08/Jun/09 9:07 PM
  2. Folder modedit.png
    54 kB
    21/Jun/09 6:11 PM
  3. Folder view.png
    61 kB
    21/Jun/09 6:11 PM
  4. IMS modedit.png
    111 kB
    08/Jun/09 8:16 PM
  5. Page modedit.png
    130 kB
    08/Jun/09 7:25 PM
  6. Resource modedit.png
    133 kB
    08/Jun/09 7:28 PM
  7. URL modedit.png
    121 kB
    08/Jun/09 8:19 PM

Issue Links

Activity

Hide
Nadav Kavalerchik added a comment -

i am missing "file choose" button/icon on the popup window of the (new) file manager.
when added "link to file or website" resource.

is this the place to report it ? (is it not implemented yet ?)

Show
Nadav Kavalerchik added a comment - i am missing "file choose" button/icon on the popup window of the (new) file manager. when added "link to file or website" resource. is this the place to report it ? (is it not implemented yet ?)
Hide
Petr Škoda (skodak) added a comment -

There is no need to report anything , the work was not even started

Show
Petr Škoda (skodak) added a comment - There is no need to report anything , the work was not even started
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <Folder modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <Folder modedit>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <Folder view>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <Folder view>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <Folder edit files>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <Folder edit files>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <Page modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <Page modedit>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <File modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <File modedit>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <Resource modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <Resource modedit>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <URL modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <URL modedit>
Hide
Petr Škoda (skodak) added a comment -

Added UI Mockup: <IMS modedit>

Show
Petr Škoda (skodak) added a comment - Added UI Mockup: <IMS modedit>
Hide
Martin Dougiamas added a comment - - edited

I've just been playing with the latest version, Petr. Looks pretty smart!

Here are some minor GUI/English things that I thought as I went through.

  • "File folder" should just be "Folder" in English I think.
  • In "Page" plugin:
  • Display ... What does Open mean? Should it possibly just be "normal" ?
  • "Print heading" should be "Display page name"
  • "Print description" should be "Display page description".
  • "Resource file" is so much like "Folder" ... it's a bit annoying. sigh.
  • We could possibly make it clearer that we are adding "supporting files" like images etc.
  • We do really have to come up with a nice way to manage the files (I know you know)
  • Why do we have a filters option here and not on Page?
  • Does popup height/width also control embedding size? It should (and thus needs rename). Also need "max" in the menu as an option for 100%.
  • Same wording issues as Page.
  • "URL"
  • I don't think we need to make a URL picker in Moodle 2.0
  • Same wording issues as Page.
  • I tried to embed a web page and it told me to click a link instead.
  • Frame worked, but we need some admin setting to disable frames (admin policy).

That's all for now!

Show
Martin Dougiamas added a comment - - edited I've just been playing with the latest version, Petr. Looks pretty smart! Here are some minor GUI/English things that I thought as I went through.
  • "File folder" should just be "Folder" in English I think.
  • In "Page" plugin:
  • Display ... What does Open mean? Should it possibly just be "normal" ?
  • "Print heading" should be "Display page name"
  • "Print description" should be "Display page description".
  • "Resource file" is so much like "Folder" ... it's a bit annoying. sigh.
  • We could possibly make it clearer that we are adding "supporting files" like images etc.
  • We do really have to come up with a nice way to manage the files (I know you know)
  • Why do we have a filters option here and not on Page?
  • Does popup height/width also control embedding size? It should (and thus needs rename). Also need "max" in the menu as an option for 100%.
  • Same wording issues as Page.
  • "URL"
  • I don't think we need to make a URL picker in Moodle 2.0
  • Same wording issues as Page.
  • I tried to embed a web page and it told me to click a link instead.
  • Frame worked, but we need some admin setting to disable frames (admin policy).
That's all for now!
Hide
Petr Škoda (skodak) added a comment - - edited

Folder:

  • File folder - renamed to Folder

Page:

  • by default only "normal" options is available which removes it completely from modedit - I agree we need better name, normal here means it open like all other modules
  • print xxx renamed in all mods

Folder x Resource file:

  • Folder may have different features like image slideshow and preview, it may list file details
  • Resource has special display options

Resource file:

  • filtering option is for uploaded files, not texts - we only had one global annoying switch until now
  • the popup width/height only control popups - it is removed if popup not allowed, and is disabled for all other display options
  • if somebody wants to embed something I would expect they would use Page instead, the resource always tries to display it as big as possible

URL:

  • you can not embed external URLs, sorry IE trouble - we would have to resort to iframes(not allowed in strict); going to add explicit warning there.
  • I found a bug in mimetype detection code that was breaking the embedding if url ended with /
  • yes, available options are fully configurable
Show
Petr Škoda (skodak) added a comment - - edited Folder:
  • File folder - renamed to Folder
Page:
  • by default only "normal" options is available which removes it completely from modedit - I agree we need better name, normal here means it open like all other modules
  • print xxx renamed in all mods
Folder x Resource file:
  • Folder may have different features like image slideshow and preview, it may list file details
  • Resource has special display options
Resource file:
  • filtering option is for uploaded files, not texts - we only had one global annoying switch until now
  • the popup width/height only control popups - it is removed if popup not allowed, and is disabled for all other display options
  • if somebody wants to embed something I would expect they would use Page instead, the resource always tries to display it as big as possible
URL:
  • you can not embed external URLs, sorry IE trouble - we would have to resort to iframes(not allowed in strict); going to add explicit warning there.
  • I found a bug in mimetype detection code that was breaking the embedding if url ended with /
  • yes, available options are fully configurable
Hide
Petr Škoda (skodak) added a comment -

There was a question why not all display types are not available in all resource or other modules in general:

1/ RESOURCELIB_DISPLAY_EMBED - files and URLs, embedding may be very problematic especially in IE; ideally only file types that are known to work should be used (images and partially PDF), please note that IE supports embedding only from the same domain (MDL-14609)

2/ RESOURCELIB_DISPLAY_FRAME - not accessible but works 100%

3/ RESOURCELIB_DISPLAY_NEW - recommended for links to external sites, can be used for links to general files too; the main reason is we do not want out users to loose navigation elements (the only option they have is to close the browser); most other uses are not recommended for accessibility reasons; I think this should be supported in all modules and activities or only in Resource file+URL

4/ RESOURCELIB_DISPLAY_DOWNLOAD - for locally stored files only, suitable for distribution of binary files; predates Portfolio - all others use cases should be handled by portfolio export code

5/ RESOURCELIB_DISPLAY_OPEN - normal opening

6/ RESOURCELIB_DISPLAY_POPUP - accessibility problems, I would prefer JS overlays with Ajax instead; implemented for BC reasons only

7/ RESOURCELIB_DISPLAY_AUTO - this just tries to guess what is usable and accessible for given file, URL, etc.

Show
Petr Škoda (skodak) added a comment - There was a question why not all display types are not available in all resource or other modules in general: 1/ RESOURCELIB_DISPLAY_EMBED - files and URLs, embedding may be very problematic especially in IE; ideally only file types that are known to work should be used (images and partially PDF), please note that IE supports embedding only from the same domain (MDL-14609) 2/ RESOURCELIB_DISPLAY_FRAME - not accessible but works 100% 3/ RESOURCELIB_DISPLAY_NEW - recommended for links to external sites, can be used for links to general files too; the main reason is we do not want out users to loose navigation elements (the only option they have is to close the browser); most other uses are not recommended for accessibility reasons; I think this should be supported in all modules and activities or only in Resource file+URL 4/ RESOURCELIB_DISPLAY_DOWNLOAD - for locally stored files only, suitable for distribution of binary files; predates Portfolio - all others use cases should be handled by portfolio export code 5/ RESOURCELIB_DISPLAY_OPEN - normal opening 6/ RESOURCELIB_DISPLAY_POPUP - accessibility problems, I would prefer JS overlays with Ajax instead; implemented for BC reasons only 7/ RESOURCELIB_DISPLAY_AUTO - this just tries to guess what is usable and accessible for given file, URL, etc.
Hide
Petr Škoda (skodak) added a comment -

I have tried to rename "Resource file" to just "File" - looks better imho.

Show
Petr Škoda (skodak) added a comment - I have tried to rename "Resource file" to just "File" - looks better imho.
Hide
Petr Škoda (skodak) added a comment -

reopening, going to clean up the lang pack and some libs issues...

Show
Petr Škoda (skodak) added a comment - reopening, going to clean up the lang pack and some libs issues...
Hide
Petr Škoda (skodak) added a comment -

reclosing

Show
Petr Škoda (skodak) added a comment - reclosing

People

Dates

  • Created:
    Updated:
    Resolved: