|
[
Permalink
| « Hide
]
Dan Marsden added a comment - 19/Aug/08 04:37 AM
Hi Andrea - thanks for the good report.
Hi Andrea - I have tried simulating this with a SCORM test package (LMSTest.zip) with specifically poking in the cmi.core.lesson_status, and cmi.core.score.raw values - first setting them incomplete/0 and then completed/1. I am unable to get the activity report to indicate a status of incomplete and 0.
Are you able to send me the SCORM package that you are using to get these results, because as it stands I cannot recreate the problem. Cheers, Piers Harding. SCORM 1.2 / Gradebook Reporting issues
Discussion: http://moodle.org/mod/forum/discuss.php?d=89479 Recently I had an issue with a site that was experiencing this issue could not get SCORM Grades / Grader Report results using the settings specified. The site was running Moodle 1.9.1+ (Build: 20080630) with Scorm 2007110500. I did eventually get the Grades / Grader Report and all student attempts to populate include the Scorm Status ($trackdata->status) to reflect the correct status which was another issue with the scorm/report.php. Find the attached Scorm_12.zip which include the complete module after it was verified as working in 1.9.1+. Files which were modified includes scorm/report.php, scorm/locallib.php and scorm/lib.php ... Of course I have tested and was able to reproduce the issues in Moodle 1.9.1+ as my tests stand they were verified by a customer whom reported the issue. The attached Scorm 1.2 module with a few patches did solve their issues. I have not taken the time here to create patches just included the patched files with the original Scorm Module where the issues were found. You should be able to create any needed patches by running: diff -ur oldfile.php newfile.php > newfile.patch Here are some screen shots Piers Harding requested of the issues I ran into with Scorm..
Thanks John - I'll get right on this, it might take a while as the differences between 1.9.1 and 1.9.2+ are quite large now.
Cheers, Hi Piers, I'm sending you by email credentials to access a test site where you can verify the issue.
Hi Andrea - I have tried out the account and seen the problem. However I cannot debug it on your site. Is it possible for me to download the SCORM package?
Also, I have applied Johns' patches. They are in HEAD and STABLE_19 - are you able to test this to see if it makes a difference for you? Thanks, Hi Piers, -thanks for the update, sent to you info about downloads.
BTW, I'm trying to test your patch against HEAD and I'm wondering how you tested it since on the build HEAD 20080821 there is no way I'm aware of to select a SCORM pack from the course file list. I'm missing something ? Thanks, Hi Andrea - as the file handling API, and the associated forms input helpers are being redeveloped at this time, this cannot be tested in HEAD. until this settles down, I am keeping track of the changes in HEAD, and doing the primary testing with 1.9. If you check out MOODLE_19_STABLE then you wil get the necessary changes.
Cheers, Hi Andrea - I have tested your SCORM package using the new debugging features that I have added recently. What it shows me is that your SCORM package did set the lesson_status but did not set the score. As it stands, Moodle mod/scorm will not grade a course unless a score is set, regardless of the grading method - here are the logs that I saw:
Fri, 22 Aug 2008 02:28:59 GMT: LMSSetValue("cmi.core.lesson_status", "completed") => 0 Cheers, Hi Piers,
thanks for the tests, we will check teh SCORM packs. Beside this, Moodle SCORM report shows "1" as score when completed: shouldn't this score be reflected on Grader report? Hi Piers,
Thank you for all your effort on mod/scorm, it is really appreciated and valuable. The SCORM pack has been retested again against moodle_19_weekly (I'll test 19_stable with your patch in the next hours) and I always get "1" as score when users completes them but grader report does not reflect AFAIK, looks like when a SCORM pack is set to report completed/incomplete and mod/scorm is set to "Learning object", in mod/scorm the score is set to "1" when students complete it . According to mod/scorm help: "Learning Object: This mode shows the number of completed/passed Learning Objects for the activity. The max value is the number of Package's Learning Objects." Thus, if the help holds true, since the SCORM pack we are testing are composed of only 1 LO, the score is "1" when LO is completed. This also explains why in such case mod/scorm grays out the "max grade" drop down. Thanks, Hi Piers,
just completed test with Moodle 1.9.2+ (Build: 20080822): the issue seems to be exactly the same as described in my
Thanks, Hi Andrea - are you able to try the patch file I have just attache:
Thanks, Hi Piers,
thanks, the patch looks working. Now:
During testing, I noticed that pre-patch already existing SCORM status seems to be reported as Incomplete while even if they has been completed. The problem is describe below.
What do you think = Could it be a side effect of your patch ? Many thanks, Hi Andrea - if I understand this correctly, what you are trying to achieve is the correct update of a grade after the patch has been applied. This should not happen, as it is the SCORM player that gives the grade of 1 (for grade by learning objects) to the grade book. As far as I know, the gradebook does not call back into the player code for regrading, or adjustments so it could not know the SCORM grading rules etc. . Given this it makes perfect sense that a student would have to go back into the activity, to trigger the correct grading adjustment. Does this make sense to you?
Cheers, Hi Pers,
what you say make perfectly sense to me. What makes less sense is the student Activity report switching back to "Incomplete" just after applying the patch for those students who completed SCORM activity before applying the patch. This means that any attempt to recalculate Many thanks, Piers,
reflecting again on your comment, I think Students should not enter the activity again to trigger the grade, since the grade of "1" is already in place when What I described is a unexpected behavior where student who completed a SCORM activity before the patch, after the patch lost the "completed" status, thus recalculating in Grader Report yields "0" for those students. Btw, wouldn't be simpler to trigger the scorm_update_grades() regardless the completed/passed status ? This would allow to get "0" when incomplete, "1" when completed and "-" when not attempted. Thanks, Hi Andrea - I have run through the complete test as you describe above, and it all works as expected. I do not get the "student A" activity report switching back to incomplete problem.
One thing that I do notice is that if I go to the ativity view outline - I don not see any activity info for SCORM objects, but if I go to the activity reports for individual SCORM activities, then I see the results attempt = 1 and score = 1 for the student. I am a bit hesitant to trigger scorm_update_grade() regardless of the completion status, as I think this is inefficient coding. From my testing, the patch I have offered would appear to calculate the right values now. There is the outstanding issue of grades for users who have completed activities in the past. This is a separate problem, and I think it should be dealt with in a one-off manner. This could be with manually forcing the grade, or the student visiting the SCORM activity one last time. Cheers, Hi Piers,
thank you very much for taking time for test. We too tested again and we found the issue not related to your patch, so from our point of view we can cosider the patch OK. The issue described may happen only if Student A reopens the SCORM and reply "No" when prompted to restart from where she left the SCORM then she closes immediately For scorm_update_grade(), I'm sure you know when it is best to trigger. About the pre-patch already existing SCORM grade, I agree with you that it can be managed forcing a grade recalculation from within the Grader report screen. Let me know If you need more from me to let the patch be part of the upcoming moodle_19_weekly. Many thanks Hi Piers,
as a partial correction of the issue described, please read as follows: The issue described may happen only if Student A reopens the SCORM and reply "No" when prompted to restart from where she left the SCORM . This way the lesson status is reset and the same happens for the SCORM grade. Uhm,
looks like the status is always reset to incomplete upon SCORM re-open. Anyway, it is a completely other story. Andrea Hi Andrea - thanks for getting back to me.
The patch has allready been applied to STABLE, so will be available in this weeks weekly build. Cheers, Piers Harding. Hi Andrea - with respect to:
"Uhm, looks like the status is always reset to incomplete upon SCORM re-open. Anyway, it is a completely other story. " I would be very interested in you looking at the debug of the SCORM object with the new debugging that I have implemented. For the grade to have been affected, it sounds Cheers, Piers, please find following the SCORM API logging report:
When a user exits the SCOROM after completing it: Tue, 26 Aug 2008 17:32:59 GMT: LMSSetValue("cmi.core.session_time", "0000:00:58.81") => 0 When a user re-opens the completed SCORM: Tue, 26 Aug 2008 17:36:21 GMT: Moodle SCORM 1.2 API Loaded, Activity: Mod 4 ter, SCO: _SCO Looks like the SCORM status is reset to incomplete. Andrea Hi Andrea - fantastic bug report! I think this may be related to an existing issue
Thanks, Hi there,
I'm not sure why this has been marked as resolved? I've just downloaded the most recent weekly build of Moodle 1.9.2 (20080903) I've added an Articulate quizmaker quiz as a SCORM package, and also an Articulate Presenter SCORM package. Both pass their results to the SCORM module OK so I know that communication between Moodle & the SCORM packages is OK. But the results do not get from the SCORM module to the gradebook. There is nothing I can do to force the gradebook to get the results. The gradebook just indicates 0 for each attempt This is an urgent issue for us. We've just upgraded a 17,000 user Moodle installation from 1.7 to 1.9, mainly for the additional capabilities the report plugins will give, but now find that the SCORM packages no longer send their information to the gradebook. Any fix will need to ensure that SCORM results are pulled retrospectively - ie. we don't want users to have to go to the SCORM packages again just to pull the results across. This is critical for us, but I'm sure we're not the only people in this situation. Is there a timescale for solving the problem? Thanks, Mark Update:
Just to clarify, with a SCORM quiz that passes a score, that score is displayed (eg. as 67% (failed)) on: 1) the entry page for the SCORM package: http://localhost/moodle/mod/scorm/view.php?id=62 It does not display on: 1) the overall report page: http://localhost/moodle/mod/scorm/report.php?id=62 For packages that are tracking complete/incomplete, a 1 or passed is shown on all the SCORM module pages, A 1 is also now shown in the Gradebook. So it looks like the complete/incomplete tracking <b>is</b> working. Mark Hi - mark. This has been marked resolved as the reporters problem has been resolved. If you have a further problem, then please supply a SCORM package, and steps to reporduce.
Cheers. Hi Piers,
This is a SCORM quiz, produced by Articulate Quizmaker. Add it to a course. Set it to Unlimited Attempts. Set it to open in a new window. Keep all the other default SCORM settings. Do the quiz. There are only three questions. When you finish the quiz, you will see the result passed to Moodle (on the view.php page) That result is not seen on the report.php page (only 0 is displayed), yet when you dig into the attempt, you can see the score recorded correctly. The score also does not appear in the gradebook. Cheers, Mark Hi Mark - I have tried on a few different configurations (WinXP/IE7, Ubuntu/FF3), without any success in launching this package. The flash componente attempts to launch and then fails - on XP it crashes IE7.
Do you have another example? Cheers, Hi Mark - I managed to sort out my environment so that I could run the test package. However - if I use the default grading method as you have said (objects), then I do get grades passed into the grade book,
and I see the results in the report for the attempt. Perhaps you can either attach screen shots of what you see (create the activity in Moodle from scratch), configuration as well as reports and grade, or email it to me directly - piers@catalyst.net.nz. Cheers, Piers Harding. Hi Piers,
From the screenshots attached, you'll see the problem I'm having. It now appears that Students' scorm quiz results are appearing in the gradebook, whereas people with admin roles don't get their quiz results. So it seems as if the issue is not as big as first appeared. But there is a problem with SCORM results interacting with the capabilities (I'm using the default Moodle capabilities setup). Thanks, Mark Hi Mark,
looking at your screenshots looks like your SCORM packages send to gradebook a passed/incomplete status rather than the real score. When users score less than minimum, they get "0", while when the score >= minimum, they get 1. When a SCORM is "passed", i.e. equal "1", User report shows 100% but this may have no relation with the real score of the SCORM quiz:. to test, try to obtain a score of 80% in your SCORM, you should get 100% in the User report and "1" in the gradebook. Andrea Thanks Andrea,
I understand what you're saying and it sort of makes sense. But, you'll see from the screenshots, that the actual percentage score is available to Moodle. Eg. Image-0012.png and Image-0014.png Am I right in thinking that the gradebook will only pick up the passed/incomplete status? I can't find any way of getting it to pick up the score itself. If that's the case then I'll leave it there. It's not really a bug, more a case of the way SCORM behaves... Cheers, Mark Mark,
you should check your SCORM packages. If they are created in Articulate Presenter (I think they are) when exporting package verify the SCORM options. If you cannot verfiy the package, try attemting the SCORM scoring 80%. If you get "1" in the Gradebook I think SCORM is sending status. Andrea Hi Mark - thanks for the screen shots - it makes it so much easier.
I have run through some more tests with your package, and it behaves correctly for both grading by "Objects", and "Highest Grade" - irrespective of what kind of user. When grading by Objects, you only register a 1 in the grade book if the student attains the pass criteria. When using "Highest Grade" then you essentially see the score figure in the grade book (%33 - 1 Q right etc.). This is a true reflection of the grading method used, as Andrea has pointed out. Cheers, HI Andrea - thanks for the help explaining things, - have you had a chance to test the patch Piers has made? -
does it resolve the issues you were seeing? - can we close this bug off? - thanks. Mark - as Andrea has mentioned, this is behaviour set by your Scorm packaging software, you might be able to modify it there. Hi Dan,
for my understanding and tests the Piers patch solves the issue I rised. Many thanks, Thanks all,
I think this has come down to my misunderstanding of the different grading methods available. Thanks for all your help. Mark We have resolved our outstanding issues with SCORM as well. Are all changes in CVS at this present time?
Thanks Piers!! Hi John - yes they are.
Cheers. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||